Skip to content

common strategy simplification#3229

Merged
dimapihtar merged 42 commits intoNVIDIA:mainfrom
dimapihtar:simplify_common_strategy
Mar 20, 2026
Merged

common strategy simplification#3229
dimapihtar merged 42 commits intoNVIDIA:mainfrom
dimapihtar:simplify_common_strategy

Conversation

@dimapihtar
Copy link
Contributor

@dimapihtar dimapihtar commented Feb 3, 2026

What does this PR do ?

Simplifies common.py strategy as a part of checkpointing simplification by droping LoadCommonStrategy, SaveCommonStrategy, TorchCommonSaveStrategy, TorchCommonLoadStrategy and their substituion with a simplier functions.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 3, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

dimapihtar and others added 7 commits February 3, 2026 12:51
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar dimapihtar marked this pull request as ready for review February 9, 2026 15:08
@dimapihtar dimapihtar requested review from a team as code owners February 9, 2026 15:08
@ko3n1g ko3n1g requested a review from a team February 9, 2026 15:08
@dimapihtar
Copy link
Contributor Author

/ok to test dde7dcc

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
Copy link
Contributor Author

/ok to test f0a3803

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar dimapihtar requested review from a team as code owners March 17, 2026 10:56
@dimapihtar
Copy link
Contributor Author

/ok to test 6f3f7d1

@dimapihtar
Copy link
Contributor Author

/ok to test 7813b47

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
Copy link
Contributor Author

/ok to test da4008e

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
Copy link
Contributor Author

/ok to test c7c8477

dimapihtar and others added 5 commits March 19, 2026 18:45
Signed-off-by: dimapihtar <dpihtar@gmail.com>
This reverts commit e07aa74.
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
Copy link
Contributor Author

/ok to test f7d7f55

@dimapihtar dimapihtar requested a review from yaoyu-33 March 19, 2026 20:08
@dimapihtar dimapihtar added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Mar 19, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Mar 20, 2026
@dimapihtar dimapihtar added this pull request to the merge queue Mar 20, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23361119806

Merged via the queue into NVIDIA:main with commit 2beb593 Mar 20, 2026
224 of 230 checks passed
@dimapihtar dimapihtar deleted the simplify_common_strategy branch March 20, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: high Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants