Skip to content

Fix: Auto enable manual registration and enhance the docummentation#3295

Merged
ericharper merged 2 commits intoNVIDIA:mainfrom
youngeunkwon0405:fsdp-ubr-ux
Apr 22, 2026
Merged

Fix: Auto enable manual registration and enhance the docummentation#3295
ericharper merged 2 commits intoNVIDIA:mainfrom
youngeunkwon0405:fsdp-ubr-ux

Conversation

@youngeunkwon0405
Copy link
Copy Markdown
Member

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
@youngeunkwon0405 youngeunkwon0405 self-assigned this Feb 6, 2026
@youngeunkwon0405 youngeunkwon0405 requested review from a team as code owners February 6, 2026 18:33
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Feb 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team February 6, 2026 18:33
@youngeunkwon0405
Copy link
Copy Markdown
Member Author

/ok to test aced81f

@cspades cspades added the Final Review PR is in the "final review" stage label Feb 6, 2026
@ericharper
Copy link
Copy Markdown
Contributor

@youngeunkwon0405 , can you fix the conflicts?

@youngeunkwon0405 youngeunkwon0405 requested review from a team as code owners April 22, 2026 16:51
@svcnvidia-nemo-ci svcnvidia-nemo-ci removed the Final Review PR is in the "final review" stage label Apr 22, 2026
@youngeunkwon0405
Copy link
Copy Markdown
Member Author

/ok to test dee1f75

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Apr 22, 2026
@ericharper ericharper added this pull request to the merge queue Apr 22, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24793943617

Merged via the queue into NVIDIA:main with commit 384e618 Apr 22, 2026
69 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants