Skip to content

Cherry-pick #3399 for Mamba Uneven PP fix#3544

Merged
ko3n1g merged 1 commit intoNVIDIA:core_r0.16.0from
kevalmorabia97:kmorabia/cherry-pick-3399
Feb 26, 2026
Merged

Cherry-pick #3399 for Mamba Uneven PP fix#3544
ko3n1g merged 1 commit intoNVIDIA:core_r0.16.0from
kevalmorabia97:kmorabia/cherry-pick-3399

Conversation

@kevalmorabia97
Copy link
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Cherry-pick #3399

Mamba implementation does not consider uneven PP and always splits layers evenly across all PP ranks resulting in silently dropping some layers!

Tested PR with Nemotron3-nano-30B (52 layers) on 8-gpu (5-7-7-7-7-7-7-5 per rank)

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

…A#3399)

Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97 kevalmorabia97 requested review from a team as code owners February 23, 2026 19:25
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 23, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kevalmorabia97 kevalmorabia97 changed the base branch from main to core_r0.16.0 February 23, 2026 19:25
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team February 23, 2026 19:25
@kevalmorabia97 kevalmorabia97 removed request for a team February 23, 2026 19:25
@kevalmorabia97 kevalmorabia97 added this to the Core 0.16 milestone Feb 23, 2026
@kevalmorabia97 kevalmorabia97 changed the title Cherry-pick #3399 Cherry-pick #3399 for Mamba Uneven PP fix Feb 23, 2026
@janEbert
Copy link
Contributor

/ok to test 62ac0e8

@janEbert janEbert added the Expert Review Apply this label to indicate that your PR is ready for expert review. label Feb 23, 2026
@ko3n1g ko3n1g merged commit bce706c into NVIDIA:core_r0.16.0 Feb 26, 2026
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick Expert Review Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants