Skip to content

Add unit test for THD#3608

Merged
yanring merged 2 commits intoNVIDIA:devfrom
kunlunl:Add_thd_unit_test
Feb 28, 2026
Merged

Add unit test for THD#3608
yanring merged 2 commits intoNVIDIA:devfrom
kunlunl:Add_thd_unit_test

Conversation

@kunlunl
Copy link
Contributor

@kunlunl kunlunl commented Feb 26, 2026

What does this PR do ?

Add unit test to compare THD format against SBHD format.
main branch #3617

Test Strategy

  1. Generate full (unsharded) data with deterministic seed on each rank.
  2. Shard inputs for both SBHD and THD formats (zigzag CP, contiguous SP).
  3. Forward pass through the same TransformerLayer.
  4. Gather outputs back to full size (with gradient support).
  5. Backward pass with format-specific grad_output handling.
  6. Compare outputs and gradients with bitwise or similarity checks.

Check Levels

  • bitwise_all: B=1, forward + backward bitwise (MockCoreAttention)
  • bitwise_fwd: B>1, forward bitwise, backward similarity (MockCoreAttention,
    THD padded to max_len so total tokens match SBHD)
  • similarity: All parallelism configs, real TE attention, similarity checks

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@kunlunl kunlunl requested review from a team as code owners February 26, 2026 08:36
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kunlunl
Copy link
Contributor Author

kunlunl commented Feb 26, 2026

/ok to test b44a3b5

@kunlunl
Copy link
Contributor Author

kunlunl commented Feb 26, 2026

/ok to test 027bd1a

@kunlunl kunlunl mentioned this pull request Feb 26, 2026
6 tasks
@yanring yanring added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Feb 27, 2026
Copy link
Contributor

@yanring yanring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM—thanks for adding these great tests!

@yanring yanring enabled auto-merge February 27, 2026 08:39
@yanring yanring added this pull request to the merge queue Feb 28, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22511910500

Merged via the queue into NVIDIA:dev with commit d0e0cf0 Feb 28, 2026
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants