Skip to content

reduce the number of shared expert streams#3752

Merged
yaox12 merged 7 commits intoNVIDIA:mainfrom
xlm-research:yb/fix/reduce_num_of_shared_expert_streams
Apr 13, 2026
Merged

reduce the number of shared expert streams#3752
yaox12 merged 7 commits intoNVIDIA:mainfrom
xlm-research:yb/fix/reduce_num_of_shared_expert_streams

Conversation

@yangbofun
Copy link
Copy Markdown
Contributor

@yangbofun yangbofun commented Mar 9, 2026

What does this PR do ?

  1. Reduce the number of the share expert stream when using --moe-shared-expert-overlap true.

before:
image

after:
image

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@yangbofun yangbofun requested review from a team as code owners March 9, 2026 09:26
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 9, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 9, 2026 09:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@yangbofun yangbofun marked this pull request as ready for review March 9, 2026 09:27
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 9, 2026 09:27
@Victarry Victarry added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Mar 10, 2026
@Victarry
Copy link
Copy Markdown
Contributor

/ok to test fcb68bd

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 10, 2026
@Phlip79 Phlip79 removed Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Mar 10, 2026
@yaox12 yaox12 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Mar 11, 2026
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Mar 11, 2026
@yaox12 yaox12 enabled auto-merge April 1, 2026 06:09
@yaox12 yaox12 added the Final Review PR is in the "final review" stage label Apr 12, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 13, 2026
@ericharper
Copy link
Copy Markdown
Contributor

/ok to test 56e37da

@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Apr 13, 2026
@yaox12 yaox12 added this pull request to the merge queue Apr 13, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24336512931

Merged via the queue into NVIDIA:main with commit 6da6267 Apr 13, 2026
63 checks passed
@yangbofun yangbofun deleted the yb/fix/reduce_num_of_shared_expert_streams branch April 14, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made community-request Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants