Skip to content

Re-enable tests which were failing on #3373#3757

Merged
mathemakitten merged 3 commits intoNVIDIA:mainfrom
mathemakitten:helenn-reenable-tests-post3373
Mar 9, 2026
Merged

Re-enable tests which were failing on #3373#3757
mathemakitten merged 3 commits intoNVIDIA:mainfrom
mathemakitten:helenn-reenable-tests-post3373

Conversation

@mathemakitten
Copy link
Contributor

What does this PR do ?

We disabled these tests to merge #3373 and they need to be re-enabled.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 9, 2026 17:52
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 9, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mathemakitten mathemakitten marked this pull request as ready for review March 9, 2026 17:52
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 9, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 9, 2026 17:52
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Mar 9, 2026
@mathemakitten mathemakitten enabled auto-merge March 9, 2026 18:43
@mathemakitten mathemakitten added this pull request to the merge queue Mar 9, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22870341173

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2026
@mathemakitten mathemakitten enabled auto-merge March 9, 2026 20:48
@mathemakitten mathemakitten added this pull request to the merge queue Mar 9, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22876597761

Merged via the queue into NVIDIA:main with commit d904a68 Mar 9, 2026
52 checks passed
@mathemakitten mathemakitten deleted the helenn-reenable-tests-post3373 branch March 9, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants