Skip to content

Upgrade GitHub Actions for Node 24 compatibility#3830

Merged
ko3n1g merged 3 commits intoNVIDIA:mainfrom
ko3n1g:ko3n1g/debug/c1fba6d8a8b96af7d8d6fd440c633374e2d73a5d
Mar 12, 2026
Merged

Upgrade GitHub Actions for Node 24 compatibility#3830
ko3n1g merged 3 commits intoNVIDIA:mainfrom
ko3n1g:ko3n1g/debug/c1fba6d8a8b96af7d8d6fd440c633374e2d73a5d

Conversation

@ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Mar 12, 2026

What does this PR do ?

This builds upon #2677 and solves the workflow issue by also bumping the actions/checkout in the test action.yml file.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
@ko3n1g ko3n1g requested a review from a team as a code owner March 12, 2026 12:57
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 12, 2026 12:57
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 12, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 12, 2026
…a8b96af7d8d6fd440c633374e2d73a5d

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Contributor Author

ko3n1g commented Mar 12, 2026

/ok to test

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Contributor Author

ko3n1g commented Mar 12, 2026

/ok to test

@ko3n1g ko3n1g marked this pull request as ready for review March 12, 2026 13:19
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 12, 2026 13:20
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Mar 12, 2026
@ko3n1g ko3n1g added this pull request to the merge queue Mar 12, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23007940387

Merged via the queue into NVIDIA:main with commit 1d5e68b Mar 12, 2026
57 of 60 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/debug/c1fba6d8a8b96af7d8d6fd440c633374e2d73a5d branch March 12, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants