Skip to content

ci: Fix build-test-publish summary job always passing#3905

Merged
ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g:ko3n1g/ci/fix-build-tst-publish
Mar 17, 2026
Merged

ci: Fix build-test-publish summary job always passing#3905
ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g:ko3n1g/ci/fix-build-tst-publish

Conversation

@ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Mar 17, 2026

Summary

Test plan

  • Verify the summary job correctly fails when a matrix job (arm64/amd64) fails
  • Verify the summary job passes when all jobs succeed

🤖 Generated with Claude Code

SKIPPING_IS_ALLOWED was hardcoded to true, causing the summary job to
always exit 0 regardless of failed matrix jobs (e.g. arm64).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ko3n1g ko3n1g requested a review from a team as a code owner March 17, 2026 20:50
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 17, 2026 20:50
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 17, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 17, 2026
@ko3n1g ko3n1g marked this pull request as ready for review March 17, 2026 20:51
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 17, 2026 20:51
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Mar 17, 2026
@ko3n1g ko3n1g merged commit dbcd5d9 into NVIDIA:main Mar 17, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants