ci: Fix build-test-publish summary job always passing#3905
Merged
ko3n1g merged 1 commit intoNVIDIA:mainfrom Mar 17, 2026
Merged
ci: Fix build-test-publish summary job always passing#3905ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g merged 1 commit intoNVIDIA:mainfrom
Conversation
SKIPPING_IS_ALLOWED was hardcoded to true, causing the summary job to always exit 0 regardless of failed matrix jobs (e.g. arm64). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
kajalj22
approved these changes
Mar 17, 2026
thomasdhc
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKIPPING_IS_ALLOWEDwas hardcoded totruein the summary job, causing it to always exit 0 regardless of actual job outcomesSKIPPING_IS_ALLOWED: falsesincebuild-test-publish-wheelshas noifcondition that would legitimately skip itTest plan
🤖 Generated with Claude Code