Skip to content

Hotfix for eviction issue#3914

Merged
tdene merged 5 commits intoNVIDIA:mainfrom
tdene:tde/rl_reverse_lag_polarity
Mar 18, 2026
Merged

Hotfix for eviction issue#3914
tdene merged 5 commits intoNVIDIA:mainfrom
tdene:tde/rl_reverse_lag_polarity

Conversation

@tdene
Copy link
Contributor

@tdene tdene commented Mar 18, 2026

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 18, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@tdene tdene marked this pull request as ready for review March 18, 2026 04:11
@tdene tdene requested review from a team as code owners March 18, 2026 04:11
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 18, 2026 04:12
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 18, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Mar 18, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Mar 18, 2026
@tdene
Copy link
Contributor Author

tdene commented Mar 18, 2026

I had not accounted for chunked prefill. I've now fixed that, and tested that the fix works.

@tdene tdene enabled auto-merge March 18, 2026 09:38
@tdene tdene added this pull request to the merge queue Mar 18, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23238546285

Merged via the queue into NVIDIA:main with commit 4402add Mar 18, 2026
52 of 53 checks passed
@tdene tdene deleted the tde/rl_reverse_lag_polarity branch March 18, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants