Skip to content

Fix hybrid dynamic inference functional tests#3924

Merged
santhnm2 merged 1 commit intoNVIDIA:mainfrom
santhnm2:hybrid_functional_test_fix
Mar 18, 2026
Merged

Fix hybrid dynamic inference functional tests#3924
santhnm2 merged 1 commit intoNVIDIA:mainfrom
santhnm2:hybrid_functional_test_fix

Conversation

@santhnm2
Copy link
Contributor

What does this PR do ?

Fixes the hybrid dynamic inference functional tests.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 18, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@santhnm2
Copy link
Contributor Author

/ok to test 0d294e4

@santhnm2 santhnm2 marked this pull request as ready for review March 18, 2026 16:46
@santhnm2 santhnm2 requested a review from a team as a code owner March 18, 2026 16:46
@santhnm2 santhnm2 enabled auto-merge March 18, 2026 16:46
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 18, 2026 16:46
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made complexity: low labels Mar 18, 2026
@santhnm2 santhnm2 added this pull request to the merge queue Mar 18, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23256791610

Merged via the queue into NVIDIA:main with commit 49be885 Mar 18, 2026
227 of 231 checks passed
@santhnm2 santhnm2 deleted the hybrid_functional_test_fix branch March 18, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants