Skip to content

Refit optimization#3933

Merged
wdykas merged 12 commits intoNVIDIA:mainfrom
wdykas:refit-optimization
Mar 20, 2026
Merged

Refit optimization#3933
wdykas merged 12 commits intoNVIDIA:mainfrom
wdykas:refit-optimization

Conversation

@wdykas
Copy link
Contributor

@wdykas wdykas commented Mar 18, 2026

What does this PR do ?

does some optimizations for refit. We were having super large cpu footprint before from gathering all the meta data.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 18, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@wdykas
Copy link
Contributor Author

wdykas commented Mar 18, 2026

/ok to test a4a3380

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 18, 2026

/ok to test a4a3380

@wdykas, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@wdykas wdykas marked this pull request as ready for review March 20, 2026 13:02
@wdykas wdykas requested review from a team as code owners March 20, 2026 13:02
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 20, 2026 13:02
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Final Review PR is in the "final review" stage complexity: medium labels Mar 20, 2026
@wdykas
Copy link
Contributor Author

wdykas commented Mar 20, 2026

/ok to test 0c417bd

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 20, 2026
@wdykas wdykas enabled auto-merge March 20, 2026 13:46
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Mar 20, 2026
@wdykas
Copy link
Contributor Author

wdykas commented Mar 20, 2026

/ok to test 4acf40e

@wdykas wdykas added this pull request to the merge queue Mar 20, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23360848253

Merged via the queue into NVIDIA:main with commit 6e6f0b7 Mar 20, 2026
56 of 57 checks passed
@wdykas wdykas deleted the refit-optimization branch March 20, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants