Skip to content

ci: Fix sso users check#3938

Merged
chtruong814 merged 1 commit intoNVIDIA:mainfrom
chtruong814:chtruong/fix-sso
Mar 19, 2026
Merged

ci: Fix sso users check#3938
chtruong814 merged 1 commit intoNVIDIA:mainfrom
chtruong814:chtruong/fix-sso

Conversation

@chtruong814
Copy link
Contributor

What does this PR do ?

ci: Fix sso users check

The sso file name changed, so we need to update it. Passing the name via a Github variable so we can change later if needed.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested a review from a team as a code owner March 19, 2026 03:16
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 19, 2026 03:16
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 19, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 19, 2026
@chtruong814 chtruong814 marked this pull request as ready for review March 19, 2026 03:17
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 19, 2026 03:18
@chtruong814
Copy link
Contributor Author

Fast merging to fix the SSO check.

@chtruong814 chtruong814 merged commit e01d886 into NVIDIA:main Mar 19, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants