Skip to content

Guard cudagraph input copy on whether data pointers have actually changed#3948

Merged
mathemakitten merged 2 commits intoNVIDIA:mainfrom
mathemakitten:helenn-guard-cudagraph-copy
Mar 19, 2026
Merged

Guard cudagraph input copy on whether data pointers have actually changed#3948
mathemakitten merged 2 commits intoNVIDIA:mainfrom
mathemakitten:helenn-guard-cudagraph-copy

Conversation

@mathemakitten
Copy link
Contributor

What does this PR do ?

It is not always guaranteed that when A.data_ptr() == B.data_ptr(), the ._copy() will be a no-op. We guard this accordingly to avoid overhead.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@mathemakitten mathemakitten requested review from a team as code owners March 19, 2026 15:25
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 19, 2026 15:26
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 19, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 19, 2026
@mathemakitten mathemakitten marked this pull request as ready for review March 19, 2026 15:26
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 19, 2026 15:26
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Mar 19, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Mar 19, 2026
@mathemakitten mathemakitten enabled auto-merge March 19, 2026 17:39
@mathemakitten mathemakitten added this pull request to the merge queue Mar 19, 2026
@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23308855073

@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23309218874

@svcnvidia-nemo-ci
Copy link

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23312781417

Merged via the queue into NVIDIA:main with commit 9ff763a Mar 19, 2026
57 checks passed
@mathemakitten mathemakitten deleted the helenn-guard-cudagraph-copy branch March 19, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants