Skip to content

Fix external contributor concurrency to be global across all branches#3951

Merged
ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g:cicd/fix-external-global-concurrency
Mar 19, 2026
Merged

Fix external contributor concurrency to be global across all branches#3951
ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g:cicd/fix-external-global-concurrency

Conversation

@ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Mar 19, 2026

Summary

  • The test-queue approval bot previously enforced MAX_CONCURRENCY_EXTERNAL per branch (main/dev/others), allowing up to 3 external workflows to run simultaneously (one per matrix cell).
  • Added matches_contributor() helper to count external workflows across all branches without branch filtering.
  • For external contributors, the running/queued count is now global; each matrix cell sees the same total, so only 1 external workflow runs at a time.
  • Lowered MAX_CONCURRENCY_EXTERNAL default from 3 to 1 to reflect the global intent.
  • Internal contributor logic is unchanged (still per-branch).

Test plan

  • Verify that with 1 external PR already running, no additional external PRs are approved regardless of which branch they target
  • Verify that internal PRs are unaffected and still respect per-branch concurrency limits

🤖 Generated with Claude Code

Previously, the test-queue approval bot enforced MAX_CONCURRENCY_EXTERNAL
per branch (main/dev/others), allowing up to 3 external workflows to run
simultaneously. Now external contributor concurrency is counted globally
across all branches, ensuring only 1 external workflow runs at a time.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ko3n1g ko3n1g requested a review from a team as a code owner March 19, 2026 15:54
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 19, 2026 15:55
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 19, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 19, 2026
@ko3n1g ko3n1g marked this pull request as ready for review March 19, 2026 15:55
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 19, 2026 15:55
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Mar 19, 2026
@ko3n1g ko3n1g merged commit c64c64b into NVIDIA:main Mar 19, 2026
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants