Fix `mtp_use_repeated_layer` behavior for GPT models by rkarimimahab · Pull Request #3965 · NVIDIA/Megatron-LM

rkarimimahab · 2026-03-20T15:27:27Z

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

I have added relevant unit tests
I have added relevant functional tests
I have added proper typing to my code Typing guidelines
I have added relevant documentation
I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

When your PR is ready, click Ready for Review.
An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
- Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch

The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

copy-pr-bot · 2026-03-20T15:27:31Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

github-actions · 2026-03-20T15:27:43Z

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

Add the oncall reviewer (optional reviewer)
Add required review teams based on your changes

See the contribution guide for more details.

deepakn94 · 2026-03-25T18:36:48Z

/ok to test bce7df2

deepakn94 · 2026-03-25T21:09:50Z

/ok to test 7b55eb9

Phlip79 · 2026-04-13T17:32:46Z

/ok to test 8f41529

yaox12 · 2026-04-14T00:35:12Z

It seems that the UT tests/unit_tests/pipeline_parallel/**/*.py always hang. Could be a bug in this PR.

guihong-nv · 2026-04-16T17:30:20Z

@rkarimimahab The CI/CD fails. Please have a look.

Phlip79 · 2026-04-30T04:05:01Z

/ok to test 914abf9

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rkarimimahab

Hi @deepakn94 sorry for delays this should be now fixed. thanks

deepakn94 · 2026-05-04T14:51:47Z

/ok to test f28a46e

svcnvidia-nemo-ci · 2026-05-04T23:18:19Z

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25348818523

svcnvidia-nemo-ci · 2026-05-05T00:37:22Z

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25351451786

svcnvidia-nemo-ci · 2026-05-05T02:58:19Z

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25355425610

added bug correction for mtp repeated

957cb55

rkarimimahab requested review from a team as code owners March 20, 2026 15:27

svcnvidia-nemo-ci marked this pull request as draft March 20, 2026 15:27

github-actions Bot added the community-request label Mar 20, 2026

deepakn94 changed the title ~~added bug correction for mtp repeated~~ Fix mtp_use_repeated_layer behavior for GPT models Mar 20, 2026

deepakn94 marked this pull request as ready for review March 20, 2026 16:22

svcnvidia-nemo-ci requested a review from a team March 20, 2026 16:23

svcnvidia-nemo-ci added the complexity: low label Mar 20, 2026

deepakn94 reviewed Mar 20, 2026

View reviewed changes

Comment thread megatron/core/models/gpt/gpt_layer_specs.py Outdated

deepakn94 approved these changes Mar 20, 2026

View reviewed changes

chtruong814 added the needs-follow-up Issue needs follow-up label Mar 22, 2026

Fix assertion error message formatting in gpt_layer_specs

9cdae57

svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Mar 24, 2026

deepakn94 and others added 2 commits March 24, 2026 09:42

Fix assertion message for MTP layers pipeline stage

58b3c83

Merge branch 'main' into rkarimimahab/repeated

bce7df2

yaoyu-33 approved these changes Mar 25, 2026

View reviewed changes

chtruong814 removed the needs-follow-up Issue needs follow-up label Mar 25, 2026

svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 25, 2026

Linting

7b55eb9

svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Mar 25, 2026

copy-pr-bot Bot temporarily deployed to test March 25, 2026 21:10 Inactive

deepakn94 enabled auto-merge March 25, 2026 21:31

Merge branch 'main' into rkarimimahab/repeated

a13f4c5

Merge branch 'main' into rkarimimahab/repeated

8f41529

copy-pr-bot Bot temporarily deployed to test April 13, 2026 17:33 Inactive

chtruong814 added waiting-for-customer and removed waiting-for-customer labels Apr 14, 2026

chtruong814 added waiting-on-customer Waiting on the original author to respond needs-follow-up Issue needs follow-up and removed needs-follow-up Issue needs follow-up waiting-on-customer Waiting on the original author to respond labels Apr 18, 2026

svcnvidia-nemo-ci added waiting-on-maintainers Waiting on maintainers to respond and removed needs-follow-up Issue needs follow-up labels Apr 21, 2026

Merge branch 'main' into rkarimimahab/repeated

914abf9

copy-pr-bot Bot temporarily deployed to test April 30, 2026 04:06 Inactive

Fix missing vp_stage in get_mtp_layer_offset call causing VPP test hangs

f27563e

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

auto-merge was automatically disabled May 4, 2026 10:31
Head branch was pushed to by a user without write access

rkarimimahab commented May 4, 2026

View reviewed changes

Merge branch 'main' into rkarimimahab/repeated

f28a46e

deepakn94 enabled auto-merge May 4, 2026 14:51

copy-pr-bot Bot temporarily deployed to test May 4, 2026 14:53 Inactive

deepakn94 added this pull request to the merge queue May 4, 2026

Merged via the queue into NVIDIA:main with commit 2194f51 May 5, 2026
59 of 62 checks passed

svcnvidia-nemo-ci removed the waiting-on-maintainers Waiting on maintainers to respond label May 5, 2026

Conversation

rkarimimahab commented Mar 20, 2026

What does this PR do ?

Contribution process

Pre-checks

Code review

Step 1: Mark PR as "Ready for Review"

Step 2: Final Review

Step 3: Approved

Merge

Uh oh!

copy-pr-bot Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

Uh oh!

deepakn94 commented Mar 25, 2026

Uh oh!

deepakn94 commented Mar 25, 2026

Uh oh!

Phlip79 commented Apr 13, 2026

Uh oh!

yaox12 commented Apr 14, 2026

Uh oh!

guihong-nv commented Apr 16, 2026

Uh oh!

Phlip79 commented Apr 30, 2026

Uh oh!

rkarimimahab left a comment

Choose a reason for hiding this comment

Uh oh!

deepakn94 commented May 4, 2026

Uh oh!

svcnvidia-nemo-ci commented May 4, 2026

Uh oh!

svcnvidia-nemo-ci commented May 5, 2026

Uh oh!

svcnvidia-nemo-ci commented May 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants