Skip to content

Refit Miscelaneous#3973

Merged
wdykas merged 19 commits intoNVIDIA:mainfrom
wdykas:refit-misc
Apr 10, 2026
Merged

Refit Miscelaneous#3973
wdykas merged 19 commits intoNVIDIA:mainfrom
wdykas:refit-misc

Conversation

@wdykas
Copy link
Copy Markdown
Contributor

@wdykas wdykas commented Mar 20, 2026

What does this PR do ?

I told Claude to optimize the memory a bit and also write a readme so this is that. Also there is some general clean up from all the changes that have been getting forced in. There will be additional testing as well.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 20, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented Mar 23, 2026

/ok to test 192ec38

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented Mar 23, 2026

/ok to test 700db17

@wdykas wdykas marked this pull request as ready for review March 24, 2026 16:04
@wdykas wdykas requested review from a team as code owners March 24, 2026 16:04
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 24, 2026 16:04
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Final Review PR is in the "final review" stage complexity: medium labels Mar 24, 2026
@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented Mar 24, 2026

@sidsingh-nvidia @santhnm2 @kvareddy not needed for the push were are on right now but whenever people have time and can take a look. This is a cleanup by Claude I reviewed that looks good and adds some documentation

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 10, 2026
@wdykas wdykas enabled auto-merge April 10, 2026 13:21
@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented Apr 10, 2026

/ok to test 4589d22

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented Apr 10, 2026

/ok to test 52e6f3e

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented Apr 10, 2026

/ok to test edb88d7

@wdykas wdykas added this pull request to the merge queue Apr 10, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24259603870

Merged via the queue into NVIDIA:main with commit 45a49eb Apr 10, 2026
62 of 63 checks passed
@wdykas wdykas deleted the refit-misc branch April 10, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants