Merged
Conversation
added 2 commits
March 23, 2026 06:54
Contributor
Author
|
/ok to test 192ec38 |
Contributor
Author
|
/ok to test 700db17 |
Contributor
Author
|
@sidsingh-nvidia @santhnm2 @kvareddy not needed for the push were are on right now but whenever people have time and can take a look. This is a cleanup by Claude I reviewed that looks good and adds some documentation |
santhnm2
approved these changes
Apr 9, 2026
shanmugamr1992
approved these changes
Apr 9, 2026
kvareddy
approved these changes
Apr 10, 2026
Contributor
Author
|
/ok to test 4589d22 |
Contributor
Author
|
/ok to test 52e6f3e |
Contributor
Author
|
/ok to test edb88d7 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24259603870 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
I told Claude to optimize the memory a bit and also write a readme so this is that. Also there is some general clean up from all the changes that have been getting forced in. There will be additional testing as well.
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.