Skip to content

Miscellaneous MTP inference fixes#4191

Merged
santhnm2 merged 15 commits intoNVIDIA:mainfrom
santhnm2:mtp_fixes
Apr 9, 2026
Merged

Miscellaneous MTP inference fixes#4191
santhnm2 merged 15 commits intoNVIDIA:mainfrom
santhnm2:mtp_fixes

Conversation

@santhnm2
Copy link
Copy Markdown
Contributor

@santhnm2 santhnm2 commented Apr 8, 2026

What does this PR do ?

Makes the following fixes for MTP:

  • Uses decode attention kernels instead of prefill kernels by gating on is_decode_only instead of max_seqlen_q > 1
  • Fixes bug with double-counting accepted tokens when comparing against max_sequence_length to determine request termination
  • Ensures that log probs / top n log probs are trimmed the same way as the tokens

Also updates the dummy rank initialization to add requests AFTER the expert parallel synchronization rather than before.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 8, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Copy Markdown
Contributor Author

santhnm2 commented Apr 8, 2026

/ok to test f499e39

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 8, 2026
@santhnm2 santhnm2 changed the title Miscellaneous MTP fixes Miscellaneous MTP inference fixes Apr 8, 2026
santhnm2 added 2 commits April 7, 2026 21:46
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Copy Markdown
Contributor Author

santhnm2 commented Apr 8, 2026

/ok to test 8dac718

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Copy Markdown
Contributor Author

santhnm2 commented Apr 8, 2026

/ok to test a39e0cb

@santhnm2 santhnm2 marked this pull request as ready for review April 8, 2026 07:35
@santhnm2 santhnm2 requested review from a team as code owners April 8, 2026 07:35
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 8, 2026 07:35
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Apr 8, 2026
santhnm2 added 3 commits April 8, 2026 10:00
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Copy Markdown
Contributor Author

santhnm2 commented Apr 8, 2026

/ok to test b3ae69a

santhnm2 added 2 commits April 8, 2026 10:33
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Copy Markdown
Contributor Author

santhnm2 commented Apr 8, 2026

/ok to test 18e171d

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Copy Markdown
Contributor Author

santhnm2 commented Apr 8, 2026

/ok to test 67c5544

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 8, 2026
santhnm2 added 3 commits April 8, 2026 16:43
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Copy Markdown
Contributor Author

santhnm2 commented Apr 8, 2026

/ok to test 83d3d18

@santhnm2 santhnm2 added this pull request to the merge queue Apr 9, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24172283439

Merged via the queue into NVIDIA:main with commit 980211a Apr 9, 2026
128 of 129 checks passed
@santhnm2 santhnm2 deleted the mtp_fixes branch April 9, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: medium Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants