build: add dynamic git-versioning and drop rc0 pre-release tag#4212
Merged
ko3n1g merged 3 commits intoNVIDIA:mainfrom Apr 9, 2026
Merged
build: add dynamic git-versioning and drop rc0 pre-release tag#4212ko3n1g merged 3 commits intoNVIDIA:mainfrom
ko3n1g merged 3 commits intoNVIDIA:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test |
thomasdhc
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
megatron/core/package_info.py: droprc0pre-release tag (PRE_RELEASE = '') and append+<short-sha>to__version__at import time using only thegitbinary.github/workflows/_build_test_publish_wheel.yml: setNO_VCS_VERSION=1in both the step env (for the hostpythoncall that computesEXPECTED_RELEASE_NUMBER) and in thedocker run -eflag (for the manylinux build container where git is unavailable)The opt-out flag
NO_VCS_VERSION=1keeps wheel version strings clean (e.g.0.18.0instead of0.18.0+abc1234) while still allowing local installs to carry the SHA for traceability.Example