Fix Slack sync for users with GitHub email privacy enabled#4220
Merged
Phlip79 merged 1 commit intoNVIDIA:mainfrom Apr 9, 2026
Merged
Fix Slack sync for users with GitHub email privacy enabled#4220Phlip79 merged 1 commit intoNVIDIA:mainfrom
Phlip79 merged 1 commit intoNVIDIA:mainfrom
Conversation
Users like cspades and rogerwaleffe have GitHub's email privacy setting enabled, so their commit author metadata uses the noreply address. Their real @nvidia.com emails only appear in Signed-off-by commit trailers. Parse these trailers as a fallback when the commit author email is a noreply address. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
/ok to test 032b8be |
cspades
approved these changes
Apr 9, 2026
chtruong814
approved these changes
Apr 9, 2026
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24169139633 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cspades,rogerwaleffe) have their commit author metadata set to the noreply address (<id>+<user>@users.noreply.github.com), causing the Slack sync script to fail to resolve their@nvidia.comemailSigned-off-bytrailers in commit messages, where the real@nvidia.comemail is present (required by DCO)Test plan
workflow_dispatchand verifycspadesandrogerwaleffeare resolved to their@nvidia.comemails fromSigned-off-bylines@nvidia.comemail🤖 Generated with Claude Code