Skip to content

fix merges_file typo in megatron_hf_tokenizer#4392

Merged
asolergi-nv merged 2 commits intoNVIDIA:mainfrom
chelseajohn:tokenizer_bug
Apr 22, 2026
Merged

fix merges_file typo in megatron_hf_tokenizer#4392
asolergi-nv merged 2 commits intoNVIDIA:mainfrom
chelseajohn:tokenizer_bug

Conversation

@chelseajohn
Copy link
Copy Markdown
Contributor

What does this PR do ?

Fixes #4391 by replacing vocab_file with merges_file in megatron_hf_tokenizer.py

@chelseajohn chelseajohn requested review from a team as code owners April 20, 2026 15:11
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 20, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft April 20, 2026 15:11
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@chelseajohn chelseajohn marked this pull request as ready for review April 20, 2026 15:12
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 20, 2026 15:12
@chelseajohn chelseajohn marked this pull request as draft April 20, 2026 15:14
@chelseajohn chelseajohn marked this pull request as ready for review April 20, 2026 15:15
@Phlip79
Copy link
Copy Markdown
Member

Phlip79 commented Apr 20, 2026

/ok to test 6ad560c

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label Apr 22, 2026
@asolergi-nv asolergi-nv enabled auto-merge April 22, 2026 17:08
@asolergi-nv asolergi-nv added the Final Review PR is in the "final review" stage label Apr 22, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 22, 2026
@asolergi-nv asolergi-nv added this pull request to the merge queue Apr 22, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24794999195

@svcnvidia-nemo-ci svcnvidia-nemo-ci removed the waiting-on-maintainers Waiting on maintainers to respond label Apr 22, 2026
Merged via the queue into NVIDIA:main with commit 60f71e1 Apr 22, 2026
72 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made community-request complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Argument Passed to _get_merges_file() Method

7 participants