Megatron-FSDP: log mcore detection only after imports succeed#4400
Merged
wujingyue merged 1 commit intoNVIDIA:mainfrom Apr 21, 2026
Merged
Megatron-FSDP: log mcore detection only after imports succeed#4400wujingyue merged 1 commit intoNVIDIA:mainfrom
wujingyue merged 1 commit intoNVIDIA:mainfrom
Conversation
Previously the "Detected Megatron Core" log was emitted before the megatron.core imports inside the try block, so when mcore isn't installed the user saw "Detected…" immediately followed by the "not installed" fallback log. Move the success-case log to after the imports, matching the pattern already in param_and_grad_buffer.py. The except-branch log stays at the top of its block since we already know mcore isn't available there. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cspades
approved these changes
Apr 20, 2026
Member
cspades
left a comment
cspades
left a comment
There was a problem hiding this comment.
THX, is this the only offender?
jaredcasper
approved these changes
Apr 20, 2026
Phlip79
approved these changes
Apr 20, 2026
Contributor
Author
|
/ok to test a5c574a |
ericharper
approved these changes
Apr 21, 2026
svcnvidia-nemo-ci
added
Approved
Contributor
Author
|
/ok to test a5c574a |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24737973357 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24741342232 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24746552914 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
megatron_fsdp.py, the"Detected Megatron Core…"log was emitted before themegatron.coreimports inside thetryblock. When mcore isn't installed, the user saw"Detected…"immediately followed by the fallback"not installed"log — confusing and misleading.Test plan
isort+python -m py_compileon the edited fileRun testslabel — log-ordering only, no behavior change)🤖 Generated with Claude Code