Skip to content

revert: replace rampup batch size scheduler with custom step batch size schedules (#3779)#4404

Merged
ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g:ko3n1g/revert/c9e03d0c3b5b437a619931503a47887bb44f743a
Apr 21, 2026
Merged

revert: replace rampup batch size scheduler with custom step batch size schedules (#3779)#4404
ko3n1g merged 1 commit intoNVIDIA:mainfrom
ko3n1g:ko3n1g/revert/c9e03d0c3b5b437a619931503a47887bb44f743a

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Apr 21, 2026

Broke compatibility with MBridge

Claude summary

Summary

Reason

Revert of: Replace rampup batch size scheduler with custom step batch size schedules (#3779)

Test plan

  • Verify batch size scheduling tests pass (tests/unit_tests/test_num_microbatches_calculator.py)
  • Verify training smoke tests pass

…ze schedules (NVIDIA#3779)

This reverts commit c9e03d0.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested review from a team as code owners April 21, 2026 08:11
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft April 21, 2026 08:11
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 21, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 21, 2026
@ko3n1g ko3n1g marked this pull request as ready for review April 21, 2026 08:11
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented Apr 21, 2026

/ok to test

@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 21, 2026 08:12
@ko3n1g ko3n1g merged commit a52112d into NVIDIA:main Apr 21, 2026
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants