Skip to content

Fix local docs building#4416

Merged
Phlip79 merged 1 commit intoNVIDIA:mainfrom
Phlip79:philip/fix-local-docs
Apr 22, 2026
Merged

Fix local docs building#4416
Phlip79 merged 1 commit intoNVIDIA:mainfrom
Phlip79:philip/fix-local-docs

Conversation

@Phlip79
Copy link
Copy Markdown
Member

@Phlip79 Phlip79 commented Apr 21, 2026

What does this PR do ?

There is a cookies pop-up that continually opens when building locally. The flag SKIP_PUBLIC_DOCS_FEATURES=true disables this.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 21, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Phlip79 Phlip79 marked this pull request as ready for review April 21, 2026 21:41
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 21, 2026 21:41
@Phlip79
Copy link
Copy Markdown
Member Author

Phlip79 commented Apr 21, 2026

/ok to test 4cd7a90

@Phlip79 Phlip79 added this pull request to the merge queue Apr 21, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24752704392

Merged via the queue into NVIDIA:main with commit 77e2dd4 Apr 22, 2026
72 checks passed
@Phlip79 Phlip79 deleted the philip/fix-local-docs branch April 22, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants