Skip to content

docs: Add SECURITY.md#4431

Merged
chtruong814 merged 1 commit intoNVIDIA:mainfrom
chtruong814:chtruong/security-md
Apr 22, 2026
Merged

docs: Add SECURITY.md#4431
chtruong814 merged 1 commit intoNVIDIA:mainfrom
chtruong814:chtruong/security-md

Conversation

@chtruong814
Copy link
Copy Markdown
Contributor

What does this PR do ?

docs: Add SECURITY.md

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft April 22, 2026 19:07
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 22, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 22, 2026
@chtruong814 chtruong814 marked this pull request as ready for review April 22, 2026 19:14
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 22, 2026 19:14
@chtruong814 chtruong814 added this pull request to the merge queue Apr 22, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the docs-only documentation only (docs or docstrings) label Apr 22, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24797671870

Merged via the queue into NVIDIA:main with commit 7073492 Apr 22, 2026
46 checks passed
@chtruong814 chtruong814 deleted the chtruong/security-md branch April 22, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-only documentation only (docs or docstrings)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants