Remove invalid timeout argument for dist.barrier#4512
Conversation
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
maanug-nv
left a comment
There was a problem hiding this comment.
lgtm, thanks for the fix
ko3n1g
left a comment
There was a problem hiding this comment.
We added this to ensure we don’t hang on failing tests for too long. Is this still guaranteed if we remove the timeout?
'timeout' is not an argument for Perhaps the barriers in unit tests should be switched to |
time.delta argument for dist.barrier
time.delta argument for dist.barriertimeout argument for dist.barrier
|
/ok to test |
@ko3n1g, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
|
/ok to test bac00ff |
|
/ok to test e8d6619 |
|
/ok to test 552bad8 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25376362717 |
What does this PR do ?
Remove invalid parameters for torch.distributed.barrier()
Issue tracking
For PRs from open-source community contributors:
Linked issue: Related to #4480
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.