mmiranda working on another set of broken links by megnvidia · Pull Request #4534 · NVIDIA/Megatron-LM

megnvidia · 2026-04-29T20:06:09Z

What does this PR do ?

working on a set of broken links

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue: no issues to link

Contribution process

Pre-checks

I have added relevant unit tests
I have added relevant functional tests
I have added proper typing to my code Typing guidelines
I have added relevant documentation
I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

When your PR is ready, click Ready for Review.
An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
- Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch

The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: meg miranda <mmiranda@nvidia.com>

copy-pr-bot · 2026-04-29T20:06:13Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

github-actions · 2026-04-29T20:06:25Z

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

Add the oncall reviewer (optional reviewer)
Add required review teams based on your changes

See the contribution guide for more details.

megnvidia · 2026-04-29T20:08:10Z

broken link spreadsheet: https://nvidia-my.sharepoint.com/:x:/r/personal/mmiranda_nvidia_com/Documents/megatron%20broken%20links.xlsx?d=w09fbce95801f4a1180cdaa36d3da2c5b&csf=1&web=1&e=Qu1q4d

megnvidia · 2026-04-29T20:10:30Z

These changes would be for latest. We can discuss if we want to do them for 0.16 as well.

to archive 0.15 content, which continues to break links can be archived:

--- Archive replicates the structure on s3
[12:49 PM]We only need to open tickets to establish redirects.
[12:49 PM]But it's a simple process

Phlip79 · 2026-04-29T23:25:20Z

 On a daily basis, track the following:

- [new issues](https://github.com/NVIDIA/Megatron-LM/issues): check to see if there are any new issues before they become out of SLA!
- [out of SLA issues](https://github.com/orgs/NVIDIA-NeMo/projects/20/views/4?sliceBy%5Bvalue%5D=NVIDIA%2FMegatron-LM): useful dashboard that tracks all out of SLA issues


This is a link that works internally. Maybe update the line to explicitly mention that?

I have got the question out to see.

I haven't received an answer from the person who generates the link report.

Let's leave it for now as is so we can move forward with getting changes in a pushed public.

I will get notified every week of this one tho....

Use this link instead please: https://github.com/NVIDIA/Megatron-LM/issues?q=is%3Aissue%20state%3Aopen%20label%3Awaiting-on-maintainers.

megnvidia

looks like i made some changes that didn't get submitted

Updated the link for Nvidia Diffusion Models to point to the GitHub repository.

Updated the parallelism selection guide with a link to supported configurations.

megnvidia

a couple of further edits

Updated the link to the dashboard for out of SLA issues.

Phlip79 · 2026-05-05T21:20:38Z

/ok to test 6a1b73e

svcnvidia-nemo-ci · 2026-05-05T21:24:36Z

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25403138307

mmiranda working on another set of broken links

b67970a

Signed-off-by: meg miranda <mmiranda@nvidia.com>

svcnvidia-nemo-ci marked this pull request as draft April 29, 2026 20:06

Merge branch 'main' into mmiranda-fixing-links-again

e638dab

megnvidia marked this pull request as ready for review April 29, 2026 20:12

svcnvidia-nemo-ci requested a review from a team April 29, 2026 20:12

Phlip79 reviewed Apr 29, 2026

View reviewed changes

Comment thread docs/models/multimodal.md Outdated

Phlip79 reviewed Apr 29, 2026

View reviewed changes

Comment thread docs/user-guide/parallelism-guide.md Outdated

megnvidia commented May 1, 2026

View reviewed changes

megnvidia added 4 commits May 1, 2026 10:41

Update multimodal.md

649f923

Fix link to Nvidia Diffusion Models in documentation

fbdfa4e

Updated the link for Nvidia Diffusion Models to point to the GitHub repository.

Add link to Megatron Bridge supported models

5593bca

Updated the parallelism selection guide with a link to supported configurations.

Merge branch 'main' into mmiranda-fixing-links-again

e742b18

megnvidia commented May 1, 2026

View reviewed changes

megnvidia added 5 commits May 4, 2026 10:04

Merge branch 'main' into mmiranda-fixing-links-again

bb7a5ca

Merge branch 'main' into mmiranda-fixing-links-again

6c4b488

Merge branch 'main' into mmiranda-fixing-links-again

c7a0142

Update link for tracking new issues in oncall.md

e37ffed

Update link for tracking out of SLA issues

6a1b73e

Updated the link to the dashboard for out of SLA issues.

Phlip79 approved these changes May 5, 2026

View reviewed changes

Phlip79 added the docs-only documentation only (docs or docstrings) label May 5, 2026

Phlip79 enabled auto-merge May 5, 2026 21:20

Phlip79 added this pull request to the merge queue May 5, 2026

Merged via the queue into NVIDIA:main with commit 6e5fb47 May 5, 2026
42 checks passed

Conversation

megnvidia commented Apr 29, 2026

What does this PR do ?

Issue tracking

Contribution process

Pre-checks

Code review

Step 1: Mark PR as "Ready for Review"

Step 2: Final Review

Step 3: Approved

Merge

Uh oh!

copy-pr-bot Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

megnvidia commented Apr 29, 2026

Uh oh!

megnvidia commented Apr 29, 2026

Uh oh!

Phlip79 Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

megnvidia May 1, 2026

Choose a reason for hiding this comment

Uh oh!

megnvidia May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Phlip79 May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

megnvidia left a comment

Choose a reason for hiding this comment

Uh oh!

megnvidia left a comment

Choose a reason for hiding this comment

Uh oh!

Phlip79 commented May 5, 2026

Uh oh!

svcnvidia-nemo-ci commented May 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants