Skip to content

Guard vocab reduce_scatter on TP > 1 #4565

Merged
ko3n1g merged 2 commits intoNVIDIA:mainfrom
mathemakitten:helenn-guard-reduction
May 2, 2026
Merged

Guard vocab reduce_scatter on TP > 1 #4565
ko3n1g merged 2 commits intoNVIDIA:mainfrom
mathemakitten:helenn-guard-reduction

Conversation

@mathemakitten
Copy link
Copy Markdown
Contributor

@mathemakitten mathemakitten commented Apr 30, 2026

What does this PR do ?

This cuts 32us per decode step when TP=1. reduce_from_tensor_model_parallel_region is a no-op but it still hits torch.autograd.Function, which does a non-trivial amount of host-side work despite the no-op (records input metadata, checks whether autograd needs to record this call, calls device guards, etc).

Verified empirically, also visible in profiling

Before:
9b | dynamic | graphs 12 | uvm 0 | requests: cli, n 1, g 10, dur 1.0e+01 r/sec 1.0e+02 | bf: 10 GB, 399 chunks [r 396, t 16384] … throughput: 40.344 tok/s … total time: 0.248s … mem 28.7/32.1 GB … steps: 10 … capture --

After:
9b | dynamic | graphs 12 | uvm 0 | requests: cli, n 1, g 10, dur 1.0e+01 r/sec 1.0e+02 | bf: 10 GB, 399 chunks [r 396, t 16384] … throughput: 57.025 tok/s … total time: 0.175s … mem 28.7/32.1 GB … steps: 10 … capture --

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@mathemakitten mathemakitten requested review from a team as code owners April 30, 2026 22:06
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft April 30, 2026 22:06
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 30, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mathemakitten mathemakitten marked this pull request as ready for review April 30, 2026 22:06
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Apr 30, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 30, 2026 22:06
@ericharper ericharper enabled auto-merge May 1, 2026 17:55
@ericharper
Copy link
Copy Markdown
Contributor

/ok to test b98698d

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels May 1, 2026
@ericharper ericharper added this pull request to the merge queue May 1, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25231090561

@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25235057109

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 2, 2026
@ko3n1g ko3n1g added this pull request to the merge queue May 2, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25263466357

Merged via the queue into NVIDIA:main with commit cf736dc May 2, 2026
72 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants