Fix Hang in tests#4575
Conversation
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
/ok to test 153003a |
|
@wdykas , is the PR ready? Still marked as draft. |
I will take it out of draft when I have merged in main which I am trying now |
|
/ok to test 6b6510f |
just marked it as not draft |
|
/ok to test 6b6510f |
|
/ok to test e2fc2f0 |
|
/ok to test 1170273 |
|
/ok to test 9e4a1f3 |
|
/ok to test 60f1997 |
|
/ok to test 60f1997 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25392190558 |
What does this PR do ?
destroy_model_parallel now destroys each NCCL subgroup tracked in _global_process_group_list (skipping the default at index 0) before nulling the python references. Without this, ProcessGroupNCCL objects and their NVLS multicast memory bindings accumulated across re-init cycles, eventually exhausting the NVLS pool and surfacing as a misleading transport/nvls.cc out of memory error.
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.