Skip to content

Fix Hang in tests#4575

Merged
wdykas merged 9 commits intoNVIDIA:mainfrom
wdykas:fix-pg
May 5, 2026
Merged

Fix Hang in tests#4575
wdykas merged 9 commits intoNVIDIA:mainfrom
wdykas:fix-pg

Conversation

@wdykas
Copy link
Copy Markdown
Contributor

@wdykas wdykas commented May 1, 2026

What does this PR do ?

destroy_model_parallel now destroys each NCCL subgroup tracked in _global_process_group_list (skipping the default at index 0) before nulling the python references. Without this, ProcessGroupNCCL objects and their NVLS multicast memory bindings accumulated across re-init cycles, eventually exhausting the NVLS pool and surfacing as a misleading transport/nvls.cc out of memory error.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@wdykas wdykas requested review from a team as code owners May 1, 2026 14:18
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 1, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft May 1, 2026 14:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 1, 2026

/ok to test 153003a

@ericharper
Copy link
Copy Markdown
Contributor

@wdykas , is the PR ready? Still marked as draft.

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 1, 2026

@wdykas , is the PR ready? Still marked as draft.

I will take it out of draft when I have merged in main which I am trying now

@wdykas wdykas marked this pull request as ready for review May 1, 2026 19:40
@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 1, 2026

/ok to test 6b6510f

@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team May 1, 2026 19:41
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Final Review PR is in the "final review" stage complexity: low labels May 1, 2026
@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 1, 2026

@wdykas , is the PR ready? Still marked as draft.

just marked it as not draft

@ericharper
Copy link
Copy Markdown
Contributor

/ok to test 6b6510f

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels May 1, 2026
Comment thread tests/unit_tests/inference/test_hybrid_moe.py
@wdykas wdykas enabled auto-merge May 2, 2026 00:01
@svcnvidia-nemo-ci svcnvidia-nemo-ci removed the Approved All necessary approvals have been made label May 4, 2026
@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 4, 2026

/ok to test e2fc2f0

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 4, 2026

/ok to test 1170273

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 5, 2026

/ok to test 9e4a1f3

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 5, 2026

/ok to test 60f1997

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 5, 2026

/ok to test 60f1997

@wdykas wdykas added this pull request to the merge queue May 5, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25392190558

Merged via the queue into NVIDIA:main with commit ae65776 May 5, 2026
189 of 190 checks passed
@wdykas wdykas deleted the fix-pg branch May 5, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants