Skip to content

Fix buffers in refit#4580

Merged
wdykas merged 5 commits intoNVIDIA:mainfrom
wdykas:refit-fix
May 5, 2026
Merged

Fix buffers in refit#4580
wdykas merged 5 commits intoNVIDIA:mainfrom
wdykas:refit-fix

Conversation

@wdykas
Copy link
Copy Markdown
Contributor

@wdykas wdykas commented May 1, 2026

What does this PR do ?

Some persistent buffers were not being synced properly in refit. This is a fix for that.
⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@wdykas wdykas requested review from a team as code owners May 1, 2026 19:04
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 1, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft May 1, 2026 19:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 1, 2026

/ok to test 9f8c74c

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 1, 2026

/ok to test b0f324c

@wdykas wdykas marked this pull request as ready for review May 4, 2026 13:05
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team May 4, 2026 13:06
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label May 4, 2026
@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 4, 2026

/ok to test 677c0b8

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels May 4, 2026
@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 4, 2026

/ok to test c8cd5b2

@wdykas
Copy link
Copy Markdown
Contributor Author

wdykas commented May 5, 2026

/ok to test f7572f5

@wdykas wdykas added this pull request to the merge queue May 5, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25380064991

Merged via the queue into NVIDIA:main with commit 4397e07 May 5, 2026
187 checks passed
@wdykas wdykas deleted the refit-fix branch May 5, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low Run tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants