ci: introduce L-tier scope vocabulary via parser#4616
Closed
balasaajay wants to merge 1 commit into
Closed
Conversation
Add LEGACY_SCOPE_ALIASES in recipe_parser.py that maps legacy scope values
(mr, mr-slim, mr-github, mr-github-slim, nightly, weekly) to the new L-tier
vocabulary (L0/L1/L2/L3). The alias rewrites `scope` per workload row in
flatten_products and injects a default cadence only when the legacy name
implied a trigger (nightly -> [nightly], weekly -> [weekly]) and the
recipe has no explicit cadence set. Add `weekly` to ALLOWED_CADENCE_VALUES.
Flip in-repo CI call sites to the new tier names so new contributors only
see L0/L1: cicd-main.yml configure step picks L0/L1 instead of
mr-github-slim/mr-github; dev defaults in launch_jet_workload.py and
generate_local_jobs.py default to L1; tools/bisect.{sh,md} reference L1.
unit-tests is intentionally not aliased - .gitlab/stages/02.test.yml
still passes that exact string and the recipes still declare it. The
GitLab FUNCTIONAL_TEST_SCOPE variable is set externally and continues
to send legacy values; the alias resolves them transparently. A comment
in 04.functional-tests.yml documents this.
Recipe YAMLs are not edited; they continue to work via the alias.
Co-authored-by: Cursor <cursoragent@cursor.com>
balasaajay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add LEGACY_SCOPE_ALIASES in recipe_parser.py that maps legacy scope values (mr, mr-slim, mr-github, mr-github-slim, nightly, weekly) to the new L-tier vocabulary (L0/L1/L2/L3). The alias rewrites
scopeper workload row in flatten_products and injects a default cadence only when the legacy name implied a trigger (nightly -> [nightly], weekly -> [weekly]) and the recipe has no explicit cadence set. Addweeklyto ALLOWED_CADENCE_VALUES.Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.