Skip to content

Inference: Cache input + position ID views#4634

Merged
mathemakitten merged 4 commits intoNVIDIA:mainfrom
mathemakitten:helenn-view-cache
May 7, 2026
Merged

Inference: Cache input + position ID views#4634
mathemakitten merged 4 commits intoNVIDIA:mainfrom
mathemakitten:helenn-view-cache

Conversation

@mathemakitten
Copy link
Copy Markdown
Contributor

@mathemakitten mathemakitten commented May 5, 2026

What does this PR do ?

DynamicInferenceContext.current_input_and_position_ids() is called once per decode step and rebuilds two view tensors via gpu_view.token_to_input_ids[:n].unsqueeze(0) (same for position ids). Each [:n] + .unsqueeze(0) allocates a fresh TensorImpl on the host, which costs ~30-60µs combined per call. See NVTX range for "current_input_and_position_ids":

Screenshot 2026-05-05 at 1 26 31 PM

But the underlying GPU storage is allocated once at context construction and never reassigned; only its contents change between steps via transfer_bookkeeping_to_gpu(), so views into this storage are safe to reuse across steps (stride metadata never changes, and the cached view automatically reflects whatever the storage currently holds when the model reads from it.)

We cache the (input_ids_view, pos_ids_view) tuple keyed by num_tokens, with one entry per captured CUDA graph size + the eager fallback.

With this change we can drive down per-decode step time an extra ~40us.
Screenshot 2026-05-05 at 1 29 03 PM

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@mathemakitten mathemakitten requested review from a team as code owners May 5, 2026 20:28
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft May 5, 2026 20:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 5, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mathemakitten mathemakitten marked this pull request as ready for review May 5, 2026 20:31
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team May 5, 2026 20:32
@kvareddy kvareddy requested a review from lmcafee-nvidia May 7, 2026 14:29
Comment thread megatron/core/inference/contexts/dynamic_context.py Outdated
Comment thread megatron/core/inference/contexts/dynamic_context.py
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label May 7, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels May 7, 2026
@mathemakitten mathemakitten added this pull request to the merge queue May 7, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25517932522

Merged via the queue into NVIDIA:main with commit 1df264c May 7, 2026
71 of 73 checks passed
@mathemakitten mathemakitten deleted the helenn-view-cache branch May 7, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants