test: mark TestFusedApplyMLARope::test_forward_backward_for_q flaky_in_dev#4639
Merged
ko3n1g merged 1 commit intoNVIDIA:mainfrom May 6, 2026
Merged
Conversation
…n_dev Backward gradient assertion intermittently exceeds bf16 tolerances on the thd packed-sequence path (e.g. run 25408640123: 31 / 786,432 elements out of tolerance, max abs diff 3.02 vs allowed 0.05). The same merge-queue commit passed on rerun, confirming non-determinism in the fused kernel backward. Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test b763c08 |
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude summary
Mark
TestFusedApplyMLARope::test_forward_backward_for_qasflaky_in_dev.The backward gradient
assert_closeintermittently exceeds bf16 toleranceson the
thdpacked-sequence path. Observed failure in CI run25408640123:
The same merge-queue commit passed the unit-test job on rerun (run
25415024224),
confirming the bwd mismatch is non-deterministic in the fused
fused_apply_mla_rope_for_qkernel.Owning code:
megatron/core/fusions/fused_mla_yarn_rope_apply.py.