Skip to content

ci: update CI workflow conditions for integration tests#4658

Open
balasaajay wants to merge 1 commit into
NVIDIA:mainfrom
balasaajay:main-fix-wf-dep
Open

ci: update CI workflow conditions for integration tests#4658
balasaajay wants to merge 1 commit into
NVIDIA:mainfrom
balasaajay:main-fix-wf-dep

Conversation

@balasaajay
Copy link
Copy Markdown
Contributor

What does this PR do ?

Currently, the integration-test jobs run even when the unit-test stage fails, on every trigger except PR pushes. This change tightens the gate so that integration tests only run when units pass except for force run and bump_ci_container branch chnages.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Currently, the integration-test jobs run even when the unit-test stage fails, on every trigger except PR pushes. This change tightens the gate so that integration tests only run when units pass except for force run and bump_ci_container branch chnages.
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@balasaajay
Copy link
Copy Markdown
Contributor Author

/ok to test b74b33fb74b33f

@balasaajay
Copy link
Copy Markdown
Contributor Author

/ok to test b74b33f

@balasaajay balasaajay marked this pull request as ready for review May 7, 2026 16:34
@balasaajay balasaajay requested a review from a team as a code owner May 7, 2026 16:34
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team May 7, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants