Skip to content

Allow optimizer CG to share the same pool as full-iter CG#4698

Merged
chtruong814 merged 1 commit into
NVIDIA:mainfrom
nanz-nv:nanz/optimizer_cg_shared_pool_for_main
May 21, 2026
Merged

Allow optimizer CG to share the same pool as full-iter CG#4698
chtruong814 merged 1 commit into
NVIDIA:mainfrom
nanz-nv:nanz/optimizer_cg_shared_pool_for_main

Conversation

@nanz-nv
Copy link
Copy Markdown
Contributor

@nanz-nv nanz-nv commented May 8, 2026

What does this PR do ?

Allow optimizer cuda graph and eval graph to share the same memory pool as the full-iter train cuda graph. This can be done through cuda_graph_use_single_mempool, which is default to True. This flag was used by local partial cuda graph to opt in for mempool sharing among graphs. Updated the doc string for this knob as the local cuda graph now doesn't rely on this flag anymore and does the sharing unconditionally.

dev PR: #4521

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@nanz-nv nanz-nv requested review from a team as code owners May 8, 2026 09:00
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 8, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft May 8, 2026 09:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@Phlip79 Phlip79 added the 26.06 label May 12, 2026
@Phlip79 Phlip79 marked this pull request as ready for review May 16, 2026 19:53
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team May 16, 2026 19:53
@nanz-nv nanz-nv force-pushed the nanz/optimizer_cg_shared_pool_for_main branch from 0d4e102 to 12f0be3 Compare May 19, 2026 01:00
@nanz-nv
Copy link
Copy Markdown
Contributor Author

nanz-nv commented May 19, 2026

/ok to test 12f0be3

Comment thread megatron/core/transformer/transformer_config.py
Comment thread megatron/core/transformer/transformer_config.py
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label May 19, 2026
@ericharper ericharper enabled auto-merge May 20, 2026 18:53
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels May 20, 2026
@ericharper ericharper added this pull request to the merge queue May 20, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26183329402

@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26187096065

@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26198239027

@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26200799152

@chtruong814 chtruong814 removed this pull request from the merge queue due to a manual request May 21, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26204531588

@chtruong814 chtruong814 added this pull request to the merge queue May 21, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26207957991

Merged via the queue into NVIDIA:main with commit daec17c May 21, 2026
81 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26.06 Approved All necessary approvals have been made complexity: low nemotron

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants