Revert "Add Python-side guardrail for HybridEP InfiniBand limit and rename seq_len (#4094)"#4718
Merged
ko3n1g merged 1 commit intoNVIDIA:mainfrom May 11, 2026
Conversation
…ename seq_len (NVIDIA#4094)" This reverts commit a08e259. Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test |
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
#4094 forced us to reduce perf for nemotron3, qwen3 moe 30B and qwen3 -vl by reducing MBS. Reverting until we find a more fine-grained solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Revert PR #4094 ("Add Python-side guardrail for HybridEP InfiniBand limit and rename seq_len").
Why
The guardrail at
megatron/core/transformer/moe/fused_a2a.py:398is overly conservative — it raisesValueErrorfortx_depth = 3*num_tokens + 1 >= 65536, citing InfiniBand'stx_depth < 65536limit. Empirically, DeepEP / the underlying RDMA stack already handles dispatch attx_depth = 98305without crashing on the affected GB300/B300 clusters; the Python pre-check rejects workloads that would have run fine.Evidence
End-to-end re-test of every test that the guardrail was preventing from running, with the revert applied:
9924c3f205(this PR's HEAD)dgxctestingtemp-nemofw-nightly.50777079(the same nightly that contains the guardrail baked-in, with the revert overlaid at runtime)main(originalMBS=4/8values, not halved)nemotron_3_nano_8gpu_b300_bf16_perfnemotron_3_nano_8gpu_b300_fp8_mx_perfnemotron_3_nano_8gpu_gb300_bf16_perfnemotron_3_nano_8gpu_gb300_fp8_mx_perfqwen3_30b_a3b_64gpu_b300_bf16_perfqwen3_30b_a3b_64gpu_b300_fp8_mx_perfqwen3_30b_a3b_64gpu_gb300_bf16_perfqwen3_30b_a3b_64gpu_gb300_fp8_mx_perfqwen3_vl_30b_a3b_8gpu_gb300_bf16_perf(I'll update the table with the 2 remaining results when they land.)
Path forward
max_qp_wrreported by the IB device at runtime), and behind a feature flag so platforms where it's wrong can opt out.warnings.warnor a try/except wrapper around the dispatch call would achieve that without rejecting valid configurations.Test plan
Run testslabel triggers MCore unit tests