Skip to content

test: add inference performance test harness for GPT 583M, hybrid 2B,…#4806

Merged
shanmugamr1992 merged 7 commits into
NVIDIA:mainfrom
shanmugamr1992:perf-tests
May 20, 2026
Merged

test: add inference performance test harness for GPT 583M, hybrid 2B,…#4806
shanmugamr1992 merged 7 commits into
NVIDIA:mainfrom
shanmugamr1992:perf-tests

Conversation

@shanmugamr1992
Copy link
Copy Markdown
Contributor

… GPT 16B

Adds tests/performance_tests/, a server+client benchmark harness that spins up tools.run_dynamic_text_generation_server, sweeps batch sizes against the OpenAI-compatible /v1/completions endpoint, and compares throughput / avg- p50-p99 latency / TPOT against checked-in baseline_values.json with a 10% tolerance. Vendored from /Users/shanmugamr/inference-bench and adapted to work inside the existing cog + nemo-run CI flow.

Three test cases shipped with baselines captured on cw-dfw H100:

  • gpt/gpt_583m_perf: 4 batches (1, 8, 32, 128), ~5 min
  • hybrid/hybrid_2b_perf: 4 batches (1, 8, 32, 128), ~8 min
  • gpt/gpt_16b_perf: 3 batches (1, 8, 32), ~13 min

CI recipes in tests/test_utils/recipes/h100/{gpt,hybrid}-perf.yaml trigger on every MR via the existing mr-github scope (alongside functional tests).

Skill + slash command for human-driven runs live under skills/run-performance-tests/ and .claude/commands/.

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

… GPT 16B

Adds tests/performance_tests/, a server+client benchmark harness that spins
up `tools.run_dynamic_text_generation_server`, sweeps batch sizes against the
OpenAI-compatible `/v1/completions` endpoint, and compares throughput / avg-
p50-p99 latency / TPOT against checked-in baseline_values.json with a 10%
tolerance. Vendored from /Users/shanmugamr/inference-bench and adapted to
work inside the existing cog + nemo-run CI flow.

Three test cases shipped with baselines captured on cw-dfw H100:
- gpt/gpt_583m_perf: 4 batches (1, 8, 32, 128), ~5 min
- hybrid/hybrid_2b_perf: 4 batches (1, 8, 32, 128), ~8 min
- gpt/gpt_16b_perf: 3 batches (1, 8, 32), ~13 min

CI recipes in tests/test_utils/recipes/h100/{gpt,hybrid}-perf.yaml trigger on
every MR via the existing mr-github scope (alongside functional tests).

Skill + slash command for human-driven runs live under
skills/run-performance-tests/ and .claude/commands/.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@shanmugamr1992 shanmugamr1992 requested a review from a team as a code owner May 14, 2026 19:34
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 14, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft May 14, 2026 19:35
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@shanmugamr1992 shanmugamr1992 marked this pull request as ready for review May 15, 2026 18:14
@shanmugamr1992
Copy link
Copy Markdown
Contributor Author

/ok to test b90fdcd

@shanmugamr1992
Copy link
Copy Markdown
Contributor Author

/ok to test 08e3c68

@santhnm2
Copy link
Copy Markdown
Contributor

/ok to test 08e3c68

@shanmugamr1992
Copy link
Copy Markdown
Contributor Author

/ok to test 1e73e1e

@shanmugamr1992
Copy link
Copy Markdown
Contributor Author

/ok to test ce2c8c9

Comment thread skills/run-performance-tests/SKILL.md Outdated
@@ -0,0 +1,167 @@
---
name: run-performance-tests
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make this skill more generic rather than specific to your user and the cluster? I would recommend removing your username, cluster name, and cluster host.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh sorry this was not even supposed to be inside. Will remove it

These were committed by mistake in 1404dbe; they're local-only Claude
Code workflow files and should not live in the repo.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@shanmugamr1992
Copy link
Copy Markdown
Contributor Author

/ok to test b571da0

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label May 19, 2026
@tdene tdene self-requested a review May 20, 2026 00:21
@shanmugamr1992 shanmugamr1992 added this pull request to the merge queue May 20, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26169622887

Merged via the queue into NVIDIA:main with commit 23ba357 May 20, 2026
80 of 82 checks passed
@shanmugamr1992 shanmugamr1992 deleted the perf-tests branch May 20, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants