Skip to content

Also persist asymmetrical units for the MXFP8 transpose weight buffer.#4852

Merged
cspades merged 3 commits into
NVIDIA:mainfrom
cspades:cye/persist-double-buf-fix
May 21, 2026
Merged

Also persist asymmetrical units for the MXFP8 transpose weight buffer.#4852
cspades merged 3 commits into
NVIDIA:mainfrom
cspades:cye/persist-double-buf-fix

Conversation

@cspades
Copy link
Copy Markdown
Member

@cspades cspades commented May 18, 2026

What does this PR do ?

  • Needed to support Megatron-native partial CG (where allocated memory needs to be persistent or preserve host-side pointers) with MXFP8 - pass fallback_to_persistent_buffer=self.ddp_config.fsdp_db_use_persist_buf_on_alloc_fail to the MXFP8 transpose weight buffer.
    • This was completely debugged by Codex!

Tested Megatron-native partial CG on this branch: https://github.com/cspades/Megatron-LM/tree/xren/nemotron_fsdp_partcg_mambashard

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@cspades cspades self-assigned this May 18, 2026
@cspades cspades requested review from a team as code owners May 18, 2026 19:15
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft May 18, 2026 19:16
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 18, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cspades cspades added bug Something isn't working module: megatron-fsdp labels May 18, 2026
… as well!

Signed-off-by: Cory Ye <cye@nvidia.com>
Copy link
Copy Markdown
Contributor

@wujingyue wujingyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. Can you add a unit or functional test for this? Someone may accidentally regress this behavior later, and having test coverage would make future PR review less intensive.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label May 20, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels May 21, 2026
…rsistence works.

Signed-off-by: Cory Ye <cye@nvidia.com>
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26213025547

Merged via the queue into NVIDIA:main with commit 6576040 May 21, 2026
73 checks passed
@cspades cspades deleted the cye/persist-double-buf-fix branch May 21, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made bug Something isn't working complexity: low module: megatron-fsdp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants