Stage 1 deprecation: remove user-facing static inference surface#4880
Open
shanmugamr1992 wants to merge 2 commits into
Open
Stage 1 deprecation: remove user-facing static inference surface#4880shanmugamr1992 wants to merge 2 commits into
shanmugamr1992 wants to merge 2 commits into
Conversation
Deletes the user-facing static-inference entry points in favor of the
already-existing DynamicInferenceEngine, which subsumes both static and
continuous-batching workloads. The shared StaticInferenceContext /
InferenceParams param-bag is kept for the model code (T5, BERT, Mamba,
LLaVA, hybrid, MTP, MLA, rotary/relative embeddings, SSM), which will
be migrated in a separate follow-up.
Removed:
- megatron/core/inference/engines/static_engine.py (StaticInferenceEngine)
- megatron/core/inference/engines/mcore_engine.py (MCoreEngine alias)
- megatron/core/inference/text_generation_server/{text_generation_server,
run_mcore_engine,tokenization}.py and endpoints/ (legacy Flask server)
- examples/inference/gpt/gpt_static_inference.py and its launcher
- examples/inference/t5/simple_t5_batch_inference.py
- tools/run_text_generation_server.py and hybrid wrappers
- 9 static functional test directories (gpt/moe/hybrid) + 3 recipe YAMLs
- tests/unit_tests/inference/engines/test_static_engine.py
- tests/unit_tests/test_inference.py (legacy Flask server test)
- 8 shell launcher scripts that invoked the deleted tools
Updated:
- engines/__init__.py drops the StaticInferenceEngine re-export
- tools/run_inference_performance_test.py: drop --engine-type static path
- examples/multimodal/run_text_generation.py: --use-mcore-inference now
raises NotImplementedError pointing at DynamicInferenceEngine
- examples/inference/README.md, mixtral/README.md, mamba/README.md
rewritten to point at gpt_dynamic_inference.py /
tools/run_dynamic_text_generation_server.py
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
…te-static # Conflicts: # tests/functional_tests/test_cases/moe/gpt_static_inference_cuda_graphs_pad_tp4_pp1_ep4_16B_logitsmatch/model_config.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the user-facing static-inference entry points in favor of the already-existing DynamicInferenceEngine, which subsumes both static and continuous-batching workloads. The shared StaticInferenceContext / InferenceParams param-bag is kept for the model code (T5, BERT, Mamba, LLaVA, hybrid, MTP, MLA, rotary/relative embeddings, SSM), which will be migrated in a separate follow-up.
Removed:
Updated:
What does this PR do ?
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.