Skip to content

Update the hf_ptq.yaml#1175

Merged
cjluo-nv merged 2 commits intomainfrom
chenjiel/fix_hf_ptq_launcher
Apr 3, 2026
Merged

Update the hf_ptq.yaml#1175
cjluo-nv merged 2 commits intomainfrom
chenjiel/fix_hf_ptq_launcher

Conversation

@cjluo-nv
Copy link
Copy Markdown
Collaborator

@cjluo-nv cjluo-nv commented Apr 3, 2026

What does this PR do?

Type of change: Bug fix

Fix the CLI override example comment in tools/launcher/examples/Qwen/Qwen3-8B/hf_ptq.yaml by adding a missing -- (double-dash separator) to the task_0.args override.

Without the -- separator, the --quant flag would be parsed as an argument to the launcher/download script rather than being passed through to the PTQ script (huggingface_example.sh). This aligns the comment example with the actual task_0.args definition in the YAML (line 42), which already correctly includes the -- separator.

Testing

Verified the comment now matches the actual args format used in the YAML config.

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: N/A
  • Did you update Changelog?: N/A

Summary by CodeRabbit

  • Documentation
    • Updated example configuration to correct command-line parameter formatting in commented usage example.

Signed-off-by: Chenjie Luo <chenjiel@nvidia.com>
@cjluo-nv cjluo-nv requested a review from ChenhanYu April 3, 2026 17:45
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 35e79cec-5400-4e97-808e-c1981e8f3934

📥 Commits

Reviewing files that changed from the base of the PR and between f521cfe and e7df177.

📒 Files selected for processing (1)
  • tools/launcher/examples/Qwen/Qwen3-8B/hf_ptq.yaml

📝 Walkthrough

Walkthrough

A commented CLI override example in the Qwen3-8B configuration file is updated to include an extra literal -- before the --quant flag in the pipeline task arguments string.

Changes

Cohort / File(s) Summary
Configuration Example
tools/launcher/examples/Qwen/Qwen3-8B/hf_ptq.yaml
Updated commented CLI override example to insert an extra -- before --quant nvfp4, changing the command-line argument format in the pipeline task configuration string.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update the hf_ptq.yaml' is vague and does not clearly convey what specific change was made. While it references the file being modified, it lacks specificity about the actual update (e.g., fixing a CLI override example with an extra '--' character). Consider a more descriptive title that specifies the nature of the update, such as 'Fix CLI override example in hf_ptq.yaml launcher configuration' or 'Correct quant argument formatting in hf_ptq.yaml'.
Security Anti-Patterns ❓ Inconclusive Unable to execute shell commands to verify file contents and changes Please provide the actual file contents and git diff output to complete verification
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiel/fix_hf_ptq_launcher

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-03 19:05 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.67%. Comparing base (9aab38c) to head (ace0e9e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1175   +/-   ##
=======================================
  Coverage   74.67%   74.67%           
=======================================
  Files         349      349           
  Lines       39856    39856           
=======================================
  Hits        29764    29764           
  Misses      10092    10092           
Flag Coverage Δ
unit 54.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cjluo-nv cjluo-nv enabled auto-merge (squash) April 3, 2026 18:37
@cjluo-nv cjluo-nv merged commit 18ce04f into main Apr 3, 2026
38 checks passed
@cjluo-nv cjluo-nv deleted the chenjiel/fix_hf_ptq_launcher branch April 3, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants