Conversation
Signed-off-by: Chenjie Luo <chenjiel@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA commented CLI override example in the Qwen3-8B configuration file is updated to include an extra literal Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
=======================================
Coverage 74.67% 74.67%
=======================================
Files 349 349
Lines 39856 39856
=======================================
Hits 29764 29764
Misses 10092 10092
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Type of change: Bug fix
Fix the CLI override example comment in
tools/launcher/examples/Qwen/Qwen3-8B/hf_ptq.yamlby adding a missing--(double-dash separator) to thetask_0.argsoverride.Without the
--separator, the--quantflag would be parsed as an argument to the launcher/download script rather than being passed through to the PTQ script (huggingface_example.sh). This aligns the comment example with the actualtask_0.argsdefinition in the YAML (line 42), which already correctly includes the--separator.Testing
Verified the comment now matches the actual args format used in the YAML config.
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/ASummary by CodeRabbit