Ssameni/puzzletron bypass 3 integration#1470
Draft
Separius wants to merge 5 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
674b33c to
cbfd350
Compare
Signed-off-by: Sepehr Sameni <ssameni@nvidia.com>
Signed-off-by: Sepehr Sameni <ssameni@nvidia.com>
cbfd350 to
00c7d13
Compare
Signed-off-by: Sepehr Sameni <ssameni@nvidia.com>
Signed-off-by: Sepehr Sameni <ssameni@nvidia.com>
Signed-off-by: Sepehr Sameni <ssameni@nvidia.com>
00c7d13 to
a715b55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 3 of 3 in the Puzzletron bypass/local-distillation stack.
This PR wires the bypass distillation core into the full Puzzletron pipeline and adds runnable configs, docs, and end-to-end GPU
coverage.
Stack:
ssameni/puzzletron-bypass-1-prereqs: shared prerequisitesssameni/puzzletron-bypass-2-core: bypass distillation coreWhat Changed
target_num_kv_heads.Why
The previous PR adds the bypass training engine, but Puzzletron still needs pipeline wiring so bypass-trained blocks become usable
replacement-library candidates.
This PR keeps that integration separate from the core engine so reviewers can focus on pipeline behavior, config surface,
replacement-library semantics, and end-to-end coverage.
Tests
Added/updated coverage for: