Skip to content

ci: scope bump_uv_lock change detection to uv.lock#1892

Merged
kevalmorabia97 merged 1 commit into
NVIDIA:mainfrom
arham766:ci-uv-lock-diff-scope
Jul 5, 2026
Merged

ci: scope bump_uv_lock change detection to uv.lock#1892
kevalmorabia97 merged 1 commit into
NVIDIA:mainfrom
arham766:ci-uv-lock-diff-scope

Conversation

@arham766

@arham766 arham766 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Type of change: Bug fix

The torch-override step rewrites pyproject.toml via toml.load/toml.dump, which drops comments and reformats the file, so the unscoped git diff --quiet was always dirty and changed=false unreachable. In a week where uv lock --upgrade produces no changes, the create-pull-request step stages nothing and git commit exits 1, failing the scheduled run instead of no-oping. Scoping the diff to uv.lock restores the intended detection.

Usage

N/A — CI workflow configuration change.

Testing

Reproduced the failure locally by executing the workflow's steps in a clean checkout: after the toml mutation, unscoped git diff --quiet exits 1 with uv.lock byte-identical, and git add uv.lock && git commit -s -m x exits 1. With git diff --quiet -- uv.lock, the no-update path correctly yields changed=false. YAML validated.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: N/A (workflow config; validated as described above)
  • Did you update Changelog?: N/A (CI-only change)
  • Did you get Claude approval on this PR?: N/A (external contributor; cannot trigger /claude review)

Additional Information

Part of #1890 (item 2).

The torch-override step rewrites pyproject.toml via toml.load/toml.dump,
which drops comments and reformats the file, so 'git diff --quiet' is
always dirty and changed=false is unreachable. In a week where
'uv lock --upgrade' changes nothing, the create-pull-request step then
stages nothing and 'git commit' exits 1, failing the scheduled run
instead of no-oping. Scoping the diff to uv.lock restores the intended
behavior.

Signed-off-by: arham766 <arhamislam766@yahoo.com>
@arham766 arham766 requested a review from a team as a code owner July 2, 2026 21:27
@arham766 arham766 requested a review from kevalmorabia97 July 2, 2026 21:27
@copy-pr-bot

copy-pr-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kevalmorabia97

Copy link
Copy Markdown
Collaborator

/ok to test 47724d4

@kevalmorabia97 kevalmorabia97 enabled auto-merge (squash) July 5, 2026 11:06
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.21%. Comparing base (4b9225b) to head (47724d4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1892   +/-   ##
=======================================
  Coverage   70.21%   70.21%           
=======================================
  Files         515      515           
  Lines       57244    57244           
=======================================
  Hits        40196    40196           
  Misses      17048    17048           
Flag Coverage Δ
unit 54.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97 kevalmorabia97 merged commit ecc1e4f into NVIDIA:main Jul 5, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants