Skip to content

Minitron pruning refactor [2/2]: De-couple importance estimator from Dynamic Module#693

Merged
kevalmorabia97 merged 1 commit intomainfrom
kmorabia/decouple-dm-importance
Dec 16, 2025
Merged

Minitron pruning refactor [2/2]: De-couple importance estimator from Dynamic Module#693
kevalmorabia97 merged 1 commit intomainfrom
kmorabia/decouple-dm-importance

Conversation

@kevalmorabia97
Copy link
Copy Markdown
Collaborator

@kevalmorabia97 kevalmorabia97 commented Dec 15, 2025

What does this PR do?

  • Code refactor, no logic change
  • De-couple Minitron pruning importance estimator from Dynamic Module so its easy to configure different importance logic for pruning

Testing

  • CI/CD tests passing
  • Compare mmlu on pruned Qwen3-8B with previous and current implementation
  • Compare mmlu on pruned Qwen3-30B-A3B with previous and current implementation (lot of variance in results, some pruning configs better some worse)
  • Compare mmlu on pruned Nemotron-Nano-v2-9B with previous and current implementation

@kevalmorabia97 kevalmorabia97 requested a review from a team as a code owner December 15, 2025 19:00
@kevalmorabia97 kevalmorabia97 changed the title Minitron pruning refactor [2/2]: De-couple Minitron pruning importance estimator from Dynamic Module Minitron pruning refactor [2/2]: De-couple importance estimator from Dynamic Module Dec 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.72%. Comparing base (10d0fec) to head (e1c884e).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #693   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         192      192           
  Lines       18828    18828           
=======================================
  Hits        14070    14070           
  Misses       4758     4758           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97 kevalmorabia97 force-pushed the kmorabia/decouple-dm-importance branch from 60b0170 to e1c884e Compare December 16, 2025 13:04
@kevalmorabia97 kevalmorabia97 requested a review from a team as a code owner December 16, 2025 13:04
Comment thread tox.ini
@kevalmorabia97 kevalmorabia97 merged commit 5c194b3 into main Dec 16, 2025
73 of 83 checks passed
@kevalmorabia97 kevalmorabia97 deleted the kmorabia/decouple-dm-importance branch December 16, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants