Skip to content

Upgrade GitHub Actions for Node 24 compatibility#698

Merged
kevalmorabia97 merged 1 commit intoNVIDIA:mainfrom
salmanmkc:upgrade-github-actions-node24
Dec 16, 2025
Merged

Upgrade GitHub Actions for Node 24 compatibility#698
kevalmorabia97 merged 1 commit intoNVIDIA:mainfrom
salmanmkc:upgrade-github-actions-node24

Conversation

@salmanmkc
Copy link
Copy Markdown
Contributor

Summary

Upgrade GitHub Actions to their latest versions to ensure compatibility with Node 24, as Node 20 will reach end-of-life in April 2026.

Changes

Action Old Version(s) New Version Release Files
actions/checkout v4 v6 Release _example_tests_runner.yml, code_quality.yml, example_tests.yml, gpu_tests.yml, pages.yml, unit_tests.yml
actions/setup-python v5 v6 Release code_quality.yml, pages.yml, unit_tests.yml

Context

Per GitHub's announcement, Node 20 is being deprecated and runners will begin using Node 24 by default starting March 4th, 2026.

Why this matters

  • Node 20 EOL: April 2026
  • Node 24 default: March 4th, 2026
  • Action: Update to latest action versions that support Node 24

Security Note

Actions that were previously pinned to commit SHAs remain pinned to SHAs (updated to the latest release SHA) to maintain the security benefits of immutable references.

Testing

These changes only affect CI/CD workflow configurations and should not impact application functionality. The workflows should be tested by running them on a branch before merging.

@salmanmkc salmanmkc requested a review from a team as a code owner December 16, 2025 12:00
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Dec 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kevalmorabia97
Copy link
Copy Markdown
Collaborator

kevalmorabia97 commented Dec 16, 2025

Thanks @salmanmkc for your contribution. Please sign-off correctly so DCO check can pass. Please take a look at https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md#%EF%B8%8F-signing-your-work

@salmanmkc salmanmkc force-pushed the upgrade-github-actions-node24 branch from 513de6a to a3bb991 Compare December 16, 2025 12:11
@kevalmorabia97
Copy link
Copy Markdown
Collaborator

@salmanmkc
Copy link
Copy Markdown
Contributor Author

Still failing the DCO check: https://github.com/NVIDIA/Model-Optimizer/pull/698/checks?check_run_id=58194248822

Hm but it's signed using a signing key already

@salmanmkc
Copy link
Copy Markdown
Contributor Author

salmanmkc commented Dec 16, 2025

I'll have another look, edit: I see the problem, fixed

Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
@salmanmkc salmanmkc force-pushed the upgrade-github-actions-node24 branch from a3bb991 to df7655c Compare December 16, 2025 13:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.72%. Comparing base (b1b9321) to head (df7655c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         192      192           
  Lines       18828    18828           
=======================================
  Hits        14070    14070           
  Misses       4758     4758           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
Copy link
Copy Markdown
Collaborator

/ok to test df7655c

@kevalmorabia97 kevalmorabia97 enabled auto-merge (squash) December 16, 2025 14:54
@kevalmorabia97 kevalmorabia97 merged commit d8d5a29 into NVIDIA:main Dec 16, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants