Skip to content

Conversation

@ianm-nv
Copy link
Collaborator

@ianm-nv ianm-nv commented Apr 30, 2025

BugLink: https://bugs.launchpad.net/bugs/2109730

The following changes since commit cc323a0:

firmware: arm_ffa: Set dma_mask for ffa devices (2025-04-28 06:40:01 -0700)

are available in the Git repository at:

https://github.com/NVIDIA/NV-Kernels ianm-v6.11-PR-4.30.2025_v2

for you to fetch changes up to 684c530:

UBUNTU: [Config] nvidia-6.11: Update annotations to enable realtek R8127 module (2025-04-30 11:49:49 -0700)


Abhishek Sahu (4):
NVIDIA: SAUCE: r8127: Add Realtek r8127 ethernet driver
NVIDIA: SAUCE: r8127: Remove Realtek r8127 non required files
NVIDIA: SAUCE: r8127: Moved files from r8127/src to r8127 folder
UBUNTU: [Config] nvidia-6.11: Update annotations to enable realtek R8127 module

tbergstrom (1):
NVIDIA: SAUCE: Add r8127 in kernel build

debian.nvidia-6.11/config/annotations | 1 +
drivers/net/ethernet/realtek/Kconfig | 2 +
drivers/net/ethernet/realtek/Makefile | 1 +
drivers/net/ethernet/realtek/r8127/Kconfig | 42 +
drivers/net/ethernet/realtek/r8127/Makefile | 35 +
drivers/net/ethernet/realtek/r8127/r8127.h | 3068 ++++++++++++++++++
drivers/net/ethernet/realtek/r8127/r8127_dash.h | 261 ++
drivers/net/ethernet/realtek/r8127/r8127_firmware.h | 68 +
drivers/net/ethernet/realtek/r8127/r8127_n.c | 17824 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
drivers/net/ethernet/realtek/r8127/r8127_realwow.h | 118 +
drivers/net/ethernet/realtek/r8127/r8127_rss.h | 76 +
drivers/net/ethernet/realtek/r8127/rtl_eeprom.c | 285 ++
drivers/net/ethernet/realtek/r8127/rtl_eeprom.h | 58 +
drivers/net/ethernet/realtek/r8127/rtltool.c | 270 ++
drivers/net/ethernet/realtek/r8127/rtltool.h | 86 +
15 files changed, 22195 insertions(+)
create mode 100644 drivers/net/ethernet/realtek/r8127/Kconfig
create mode 100755 drivers/net/ethernet/realtek/r8127/Makefile
create mode 100755 drivers/net/ethernet/realtek/r8127/r8127.h
create mode 100755 drivers/net/ethernet/realtek/r8127/r8127_dash.h
create mode 100755 drivers/net/ethernet/realtek/r8127/r8127_firmware.h
create mode 100755 drivers/net/ethernet/realtek/r8127/r8127_n.c
create mode 100755 drivers/net/ethernet/realtek/r8127/r8127_realwow.h
create mode 100755 drivers/net/ethernet/realtek/r8127/r8127_rss.h
create mode 100755 drivers/net/ethernet/realtek/r8127/rtl_eeprom.c
create mode 100755 drivers/net/ethernet/realtek/r8127/rtl_eeprom.h
create mode 100755 drivers/net/ethernet/realtek/r8127/rtltool.c
create mode 100755 drivers/net/ethernet/realtek/r8127/rtltool.h

abhsahu and others added 5 commits April 30, 2025 11:49
BugLink: https://bugs.launchpad.net/bugs/2109730

Realtek R8127 driver can be downloaded from
https://www.realtek.com/Download/List?cate_id=584

Where it is maintained as out of tree module.

This patch adds the extracted content of r8127-11.014.00.tar.bz2 in
the folder drivers/net/ethernet/realtek/r8127.

4bd62fc87de32760fb1f3b9cd3ec14e933035623  r8127-11.014.00.tar.bz2

All the clean-up, makefile and Kconfig related changes will be
done in the subsequent commits. The source code contains a GPL2
compatible license. All the license information and Realtek
copyright notice will be maintained in each file and newly added files.

Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
Acked-by: Matt Ochs <mochs@nvidia.com>
Acked-by: Carol L Soto <csoto@nvidia.com>
Acked-by: Ian May <ianm@nvidia.com>
BugLink: https://bugs.launchpad.net/bugs/2109730

These files are not needed to build r8127 as part of kernel
source code build, so removed these non required files.

Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
Acked-by: Matt Ochs <mochs@nvidia.com>
Acked-by: Carol L Soto <csoto@nvidia.com>
Acked-by: Ian May <ianm@nvidia.com>
BugLink: https://bugs.launchpad.net/bugs/2109730

This commit moved all files from src folder to parent folder itself.

Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
Acked-by: Matt Ochs <mochs@nvidia.com>
Acked-by: Carol L Soto <csoto@nvidia.com>
Acked-by: Ian May <ianm@nvidia.com>
BugLink: https://bugs.launchpad.net/bugs/2109730

In the original code, r8127 driver was build as out of tree module.
This commit adds Kconfig and updates Makefile for building it
with kernel build.

r8127 driver internally uses different config flags and these are set
through EXTRA_CFLAGS.  These config flags are now set in the Makefile
with ccflags-y. All the flags, that were getting enabled by default in
the original code, have been enabled in ccflags-y. This commit is not
enabling any extra flags.

Some of the files compilation are dependent upon a particular flag.
Now, only default flags are set, so these files will become unused,
This commit has removed these files.

Signed-off-by: Terje Bergstrom <tbergstrom@nvidia.com>
Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
Acked-by: Matt Ochs <mochs@nvidia.com>
Acked-by: Carol L Soto <csoto@nvidia.com>
Acked-by: Ian May <ianm@nvidia.com>
…127 module

BugLink: https://bugs.launchpad.net/bugs/2109730

Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
Acked-by: Matt Ochs <mochs@nvidia.com>
Acked-by: Carol L Soto <csoto@nvidia.com>
Acked-by: Ian May <ianm@nvidia.com>
@ianm-nv
Copy link
Collaborator Author

ianm-nv commented Apr 30, 2025

This PR is redundant, all work is tracked in
#91

@ianm-nv ianm-nv closed this Apr 30, 2025
nvidia-bfigg pushed a commit that referenced this pull request Dec 31, 2025
Since commit dfb073d ("ptp: Return -EINVAL on ptp_clock_register if
required ops are NULL"), PTP clock registered through ptp_clock_register
is required to have ptp_clock_info.settime64 set, however, neither MVM
nor MLD's PTP clock implementation sets it, resulting in warnings when
the interface starts up, like

WARNING: drivers/ptp/ptp_clock.c:325 at ptp_clock_register+0x2c8/0x6b8, CPU#1: wpa_supplicant/469
CPU: 1 UID: 0 PID: 469 Comm: wpa_supplicant Not tainted 6.18.0+ #101 PREEMPT(full)
ra: ffff800002732cd4 iwl_mvm_ptp_init+0x114/0x188 [iwlmvm]
ERA: 9000000002fdc468 ptp_clock_register+0x2c8/0x6b8
iwlwifi 0000:01:00.0: Failed to register PHC clock (-22)

I don't find an appropriate firmware interface to implement settime64()
for iwlwifi MLD/MVM, thus instead create a stub that returns
-EOPTNOTSUPP only, suppressing the warning and allowing the PTP clock to
be registered.

Reported-by: Nathan Chancellor <nathan@kernel.org>
Closes: https://lore.kernel.org/all/20251108044822.GA3262936@ax162/
Signed-off-by: Yao Zi <ziyao@disroot.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
tested-by: damian Tometzki damian@riscv-rocks.de
Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
Acked-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20251204123204.9316-1-ziyao@disroot.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants