Skip to content

github-actions: restore patchscan in PR validation#432

Merged
nvidia-bfigg merged 1 commit into
NVIDIA:github-actionsfrom
nirmoy:codex/restore-patchscan-safe
May 21, 2026
Merged

github-actions: restore patchscan in PR validation#432
nvidia-bfigg merged 1 commit into
NVIDIA:github-actionsfrom
nirmoy:codex/restore-patchscan-safe

Conversation

@nirmoy
Copy link
Copy Markdown
Collaborator

@nirmoy nirmoy commented May 20, 2026

Summary:

  • Restore patchscan execution, reporting, and failure gating in the PR Validation workflow.
  • Keep PR title/body out of shell source by reading metadata through gh api + jq and writing it as data files.
  • Remove GitHub expression interpolation from executable run/script blocks; pass step/context values through env and validate repo, PR number, SHA, and base-ref metadata before use.
  • Update checkout, setup-python, and github-script to current Node 24 action majors.

Validation:

Local checks:

  • git diff --check upstream/github-actions..HEAD -- .github/workflows/patchscan.yml
  • YAML parse of .github/workflows/patchscan.yml
  • bash -n for all extracted run blocks
  • node --check for the github-script block
  • scanner verified no GitHub Actions expressions inside run or script blocks
  • rg found no github.event.pull_request.title/body or pull_request.title/body matches
  • actionlint is not installed locally

@nirmoy
Copy link
Copy Markdown
Collaborator Author

nirmoy commented May 20, 2026

Boro review

Latest watcher review: open review

Head: cd6a2dcec88a

This comment is maintained by nv-pr-bot. It is updated when the GitHub watcher publishes a newer review.

@nirmoy nirmoy force-pushed the codex/restore-patchscan-safe branch 2 times, most recently from a9b1655 to 9a6f391 Compare May 20, 2026 14:59
Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
@nirmoy nirmoy force-pushed the codex/restore-patchscan-safe branch from 9a6f391 to cd6a2dc Compare May 20, 2026 15:10
@nvidia-bfigg nvidia-bfigg merged commit 332667f into NVIDIA:github-actions May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants