-
Notifications
You must be signed in to change notification settings - Fork 233
[2.7] amplify tutorial updates #4089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Greptile OverviewGreptile SummaryThis PR cherry-picks updates from PR #4088 to the 2.7 branch, improving the AMPLIFY tutorial notebook with bug fixes and documentation enhancements. Key Changes:
The previously reported string interpolation issue has been properly resolved in this update. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Notebook as Jupyter Notebook
participant FLAb as FLAb Repository
participant AMPLIFY as AMPLIFY Model
participant NVFlare as NVFlare Framework
participant Clients as FL Clients (6)
User->>Notebook: Start tutorial
Notebook->>FLAb: Clone repository
FLAb-->>Notebook: Antibody dataset (6 properties)
Notebook->>AMPLIFY: Clone & install AMPLIFY
AMPLIFY-->>Notebook: 120M pretrained model
Note over Notebook,FLAb: Data Preparation Phase
loop For each task (aggregation, binding, etc.)
Notebook->>Notebook: Run combine_data.py
Notebook->>Notebook: Combine heavy/light sequences
Notebook->>Notebook: Split train/test (80/20)
end
Note over Notebook,Clients: Local Training Phase
Notebook->>NVFlare: Start local training (1 round)
NVFlare->>Clients: Distribute model to 6 clients
loop 3 local epochs
Clients->>Clients: Train on local task data
end
Clients-->>NVFlare: Return trained models
Note over Notebook,Clients: Federated Learning Phase
Notebook->>NVFlare: Start FedAvg (3 rounds)
loop 3 FL rounds
NVFlare->>Clients: Distribute global model
loop 1 local epoch
Clients->>Clients: Train on task-specific data
Clients->>Clients: Apply ExcludeParamsFilter
end
Clients-->>NVFlare: Return trunk updates (no regression head)
NVFlare->>NVFlare: Aggregate using FedAvg
NVFlare->>NVFlare: Update global model
end
Note over Notebook,User: Visualization Phase
Notebook->>Notebook: Generate RMSE plots
Notebook->>Notebook: Generate Pearson coefficient plots
Notebook-->>User: Display comparison results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
...hcare_lifescience/11.2_drug_discovery/11.2.2_drug_discovery_amplify/finetuning_amplify.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR is a cherry-pick of #4088 to the 2.7 branch, primarily adding Python 3.11 environment requirement documentation to the AMPLIFY tutorial notebook. The changes improve the setup instructions by clarifying version requirements and updating installation commands to use the more explicit python3 -m pip syntax.
Changes:
- Added prominent note about Python 3.11 requirement with warning about dependency conflicts
- Updated pip installation commands to use
python3 -m pipinstead ofpip - Reorganized documentation sections with clearer "Installation" heading
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...hcare_lifescience/11.2_drug_discovery/11.2.2_drug_discovery_amplify/finetuning_amplify.ipynb
Outdated
Show resolved
Hide resolved
...hcare_lifescience/11.2_drug_discovery/11.2.2_drug_discovery_amplify/finetuning_amplify.ipynb
Outdated
Show resolved
Hide resolved
...hcare_lifescience/11.2_drug_discovery/11.2.2_drug_discovery_amplify/finetuning_amplify.ipynb
Outdated
Show resolved
Hide resolved
...hcare_lifescience/11.2_drug_discovery/11.2.2_drug_discovery_amplify/finetuning_amplify.ipynb
Outdated
Show resolved
Hide resolved
...hcare_lifescience/11.2_drug_discovery/11.2.2_drug_discovery_amplify/finetuning_amplify.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
|
build |
|
/build |
Fixes # .
Description
cherry pick #4088 to 2.7
Types of changes
./runtest.sh.