feat: Make IAM role name configurable in CSP health monitor for EKS#877
Conversation
📝 WalkthroughWalkthroughThis change introduces optional custom IAM role name support (iamRoleName) in AWS IRSA configuration for the CSP Health Monitor Helm chart. The serviceaccount template now conditionally assigns the IAM role ARN using either a custom iamRoleName or the default pattern derived from clusterName, with supporting configuration and documentation updates. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/configuration/csp-health-monitor.md`:
- Around line 144-147: The iamRoleName field is marked "(Optional)" but is
placed inside the "### Required Fields" section; update the docs so iamRoleName
is moved out of the required block—either create a "### Optional Fields"
subsection and place iamRoleName: "" under it or relocate that line after the
required fields block—ensure the header names ("### Required Fields" and the
field key iamRoleName) are adjusted accordingly to avoid contradictory
documentation.
Summary
Type of Change
Component(s) Affected
Testing
Checklist
Testing
Completed manual testing in a dev AWS cluster. Verified that the change is working as expected with the set
iamRoleNamein thevalues.yaml:Summary by CodeRabbit
Release Notes
New Features
Documentation