Skip to content

fix: explicitly add tool.uv.managed = true to pyproject.toml files#1003

Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.3from
willkill07:wkk_tool-uv-managed-true
Oct 15, 2025
Merged

fix: explicitly add tool.uv.managed = true to pyproject.toml files#1003
rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.3from
willkill07:wkk_tool-uv-managed-true

Conversation

@willkill07
Copy link
Member

@willkill07 willkill07 commented Oct 15, 2025

Description

Help BlackDuck discover the project as a uv-managed project.

This is a no-op as uv's default of tool.uv.managed is already true.

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

  • Chores
    • Standardized project tooling by enabling managed mode across packages.
    • Consolidated configuration for consistent builds without altering runtime behavior.
    • No changes to features, APIs, or user workflows.

Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 added the improvement Improvement to existing functionality label Oct 15, 2025
@willkill07 willkill07 requested a review from a team as a code owner October 15, 2025 01:41
@willkill07 willkill07 added the non-breaking Non-breaking change label Oct 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2025

Walkthrough

Added the configuration flag managed = true under [tool.uv] across multiple package pyproject.toml files and in the repository root pyproject.toml, preserving existing config-settings = { editable_mode = "compat" }. In two files (root and nvidia_nat_llama_index), the addition appears under multiple [tool.uv] sections.

Changes

Cohort / File(s) Summary of changes
UV managed flag in packages
packages/nvidia_nat_*/pyproject.toml
Introduced managed = true under [tool.uv]; retained config-settings = { editable_mode = "compat" }. Homogeneous config-only edits across all listed packages.
Root UV managed flag
pyproject.toml
Added managed = true under two [tool.uv] sections; existing config-settings unchanged.
Multiple [tool.uv] sections noted
packages/nvidia_nat_llama_index/pyproject.toml, pyproject.toml
managed = true added in more than one [tool.uv] block within the same file; editable_mode unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title is concise at 68 characters, uses imperative mood with the verb “add,” and accurately describes the change by specifying that the tool.uv.managed = true flag is being added to pyproject.toml files. It provides clear context for reviewers and aligns with the stated style guidelines.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 184114b and ba051aa.

📒 Files selected for processing (22)
  • packages/nvidia_nat_adk/pyproject.toml (1 hunks)
  • packages/nvidia_nat_agno/pyproject.toml (1 hunks)
  • packages/nvidia_nat_all/pyproject.toml (1 hunks)
  • packages/nvidia_nat_crewai/pyproject.toml (1 hunks)
  • packages/nvidia_nat_data_flywheel/pyproject.toml (1 hunks)
  • packages/nvidia_nat_ingestion/pyproject.toml (1 hunks)
  • packages/nvidia_nat_langchain/pyproject.toml (1 hunks)
  • packages/nvidia_nat_llama_index/pyproject.toml (1 hunks)
  • packages/nvidia_nat_mcp/pyproject.toml (1 hunks)
  • packages/nvidia_nat_mem0ai/pyproject.toml (1 hunks)
  • packages/nvidia_nat_mysql/pyproject.toml (1 hunks)
  • packages/nvidia_nat_opentelemetry/pyproject.toml (1 hunks)
  • packages/nvidia_nat_phoenix/pyproject.toml (1 hunks)
  • packages/nvidia_nat_profiling/pyproject.toml (1 hunks)
  • packages/nvidia_nat_ragaai/pyproject.toml (1 hunks)
  • packages/nvidia_nat_redis/pyproject.toml (1 hunks)
  • packages/nvidia_nat_s3/pyproject.toml (1 hunks)
  • packages/nvidia_nat_semantic_kernel/pyproject.toml (1 hunks)
  • packages/nvidia_nat_test/pyproject.toml (1 hunks)
  • packages/nvidia_nat_weave/pyproject.toml (1 hunks)
  • packages/nvidia_nat_zep_cloud/pyproject.toml (1 hunks)
  • pyproject.toml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
packages/*/pyproject.toml

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

packages/*/pyproject.toml: Each package must contain a pyproject.toml
In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-
Use ~= version constraints (e.g., ~=1.0) for dependencies

Files:

  • packages/nvidia_nat_semantic_kernel/pyproject.toml
  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_mysql/pyproject.toml
  • packages/nvidia_nat_adk/pyproject.toml
  • packages/nvidia_nat_llama_index/pyproject.toml
  • packages/nvidia_nat_weave/pyproject.toml
  • packages/nvidia_nat_ragaai/pyproject.toml
  • packages/nvidia_nat_langchain/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_test/pyproject.toml
  • packages/nvidia_nat_profiling/pyproject.toml
  • packages/nvidia_nat_redis/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
  • packages/nvidia_nat_ingestion/pyproject.toml
  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_crewai/pyproject.toml
  • packages/nvidia_nat_opentelemetry/pyproject.toml
  • packages/nvidia_nat_agno/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_mcp/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
{packages/*/pyproject.toml,uv.lock}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Add new dependencies to both pyproject.toml (alphabetically) and uv.lock via uv pip install --sync

Files:

  • packages/nvidia_nat_semantic_kernel/pyproject.toml
  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_mysql/pyproject.toml
  • packages/nvidia_nat_adk/pyproject.toml
  • packages/nvidia_nat_llama_index/pyproject.toml
  • packages/nvidia_nat_weave/pyproject.toml
  • packages/nvidia_nat_ragaai/pyproject.toml
  • packages/nvidia_nat_langchain/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_test/pyproject.toml
  • packages/nvidia_nat_profiling/pyproject.toml
  • packages/nvidia_nat_redis/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
  • packages/nvidia_nat_ingestion/pyproject.toml
  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_crewai/pyproject.toml
  • packages/nvidia_nat_opentelemetry/pyproject.toml
  • packages/nvidia_nat_agno/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_mcp/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

  • Ensure the code follows best practices and coding standards. - For Python code, follow
    PEP 20 and
    PEP 8 for style guidelines.
  • Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
    Example:
    def my_function(param1: int, param2: str) -> bool:
        pass
  • For Python exception handling, ensure proper stack trace preservation:
    • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
      and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
    • When catching and logging exceptions without re-raising: always use logger.exception()
      to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

  • Confirm that copyright years are up-to date whenever a file is changed.

Files:

  • packages/nvidia_nat_semantic_kernel/pyproject.toml
  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_mysql/pyproject.toml
  • packages/nvidia_nat_adk/pyproject.toml
  • packages/nvidia_nat_llama_index/pyproject.toml
  • packages/nvidia_nat_weave/pyproject.toml
  • packages/nvidia_nat_ragaai/pyproject.toml
  • packages/nvidia_nat_langchain/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_test/pyproject.toml
  • packages/nvidia_nat_profiling/pyproject.toml
  • packages/nvidia_nat_redis/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
  • packages/nvidia_nat_ingestion/pyproject.toml
  • pyproject.toml
  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_crewai/pyproject.toml
  • packages/nvidia_nat_opentelemetry/pyproject.toml
  • packages/nvidia_nat_agno/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_mcp/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
packages/**/*

⚙️ CodeRabbit configuration file

packages/**/*: - This directory contains optional plugin packages for the toolkit, each should contain a pyproject.toml file. - The pyproject.toml file should declare a dependency on nvidia-nat or another package with a name starting
with nvidia-nat-. This dependency should be declared using ~=<version>, and the version should be a two
digit version (ex: ~=1.0).

  • Not all packages contain Python code, if they do they should also contain their own set of tests, in a
    tests/ directory at the same level as the pyproject.toml file.

Files:

  • packages/nvidia_nat_semantic_kernel/pyproject.toml
  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_mysql/pyproject.toml
  • packages/nvidia_nat_adk/pyproject.toml
  • packages/nvidia_nat_llama_index/pyproject.toml
  • packages/nvidia_nat_weave/pyproject.toml
  • packages/nvidia_nat_ragaai/pyproject.toml
  • packages/nvidia_nat_langchain/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_test/pyproject.toml
  • packages/nvidia_nat_profiling/pyproject.toml
  • packages/nvidia_nat_redis/pyproject.toml
  • packages/nvidia_nat_s3/pyproject.toml
  • packages/nvidia_nat_ingestion/pyproject.toml
  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_crewai/pyproject.toml
  • packages/nvidia_nat_opentelemetry/pyproject.toml
  • packages/nvidia_nat_agno/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml
  • packages/nvidia_nat_mcp/pyproject.toml
  • packages/nvidia_nat_zep_cloud/pyproject.toml
🧠 Learnings (1)
📚 Learning: 2025-09-23T18:39:15.023Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Applies to packages/*/pyproject.toml : In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-

Applied to files:

  • packages/nvidia_nat_data_flywheel/pyproject.toml
  • packages/nvidia_nat_ragaai/pyproject.toml
  • packages/nvidia_nat_phoenix/pyproject.toml
  • packages/nvidia_nat_redis/pyproject.toml
  • packages/nvidia_nat_ingestion/pyproject.toml
  • packages/nvidia_nat_mem0ai/pyproject.toml
  • packages/nvidia_nat_crewai/pyproject.toml
  • packages/nvidia_nat_opentelemetry/pyproject.toml
  • packages/nvidia_nat_agno/pyproject.toml
  • packages/nvidia_nat_all/pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@willkill07 willkill07 self-assigned this Oct 15, 2025
@willkill07
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit fb32d84 into NVIDIA:release/1.3 Oct 15, 2025
17 checks passed
@willkill07 willkill07 deleted the wkk_tool-uv-managed-true branch October 23, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants