fix: correct file paths in evaluate documentation#1024
fix: correct file paths in evaluate documentation#1024rapids-bot[bot] merged 1 commit intoNVIDIA:release/1.3from
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
WalkthroughDocumentation file updated with file path corrections in shell command blocks, changing example paths from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (3)docs/source/**/*.md📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
**/*⚙️ CodeRabbit configuration file
Files:
docs/source/**/*⚙️ CodeRabbit configuration file
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/merge |
False positives from the markdown link checker in CI on the CHANGELOG.md file has been annoying and unhelpful. Adding CHANGELOG.md to the markdown link checker pre-commit will save us some failed CIs. Here's an example: ``` (node:10223) [DEP0184] DeprecationWarning: Instantiating Gunzip without the 'new' keyword has been deprecated. (Use `node --trace-deprecation ...` to show where the warning was created) ERROR: 3 dead links found in CHANGELOG.md ! [✖] #1024 → Status: 502 [✖] https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/release/1.2/docs/source/extend/object-store.md → Status: 502 [✖] #110 → Status: 502 (node:10225) [DEP0184] DeprecationWarning: Instantiating Gunzip without the 'new' keyword has been deprecated. (Use `node --trace-deprecation ...` to show where the warning was created) (node:10224) [DEP0184] DeprecationWarning: Instantiating Gunzip without the 'new' keyword has been deprecated. (Use `node --trace-deprecation ...` to show where the warning was created) (node:10226) [DEP0184] DeprecationWarning: Instantiating Gunzip without the 'new' keyword has been deprecated. (Use `node --trace-deprecation ...` to show where the warning was created) ``` Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Chores** * Updated the markdown link-check pre-commit hook configuration to exclude the changelog file from link validation. This addition complements existing exclusions for package metadata documentation, improving the efficiency of continuous integration validation processes. Authors: - Bryan Bednarski (https://github.com/bbednarski9) Approvers: - Will Killian (https://github.com/willkill07) URL: #1653
False positives from the markdown link checker in CI on the CHANGELOG.md file has been annoying and unhelpful. Adding CHANGELOG.md to the markdown link checker pre-commit will save us some failed CIs. Here's an example: ``` (node:10223) [DEP0184] DeprecationWarning: Instantiating Gunzip without the 'new' keyword has been deprecated. (Use `node --trace-deprecation ...` to show where the warning was created) ERROR: 3 dead links found in CHANGELOG.md ! [✖] NVIDIA#1024 → Status: 502 [✖] https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/release/1.2/docs/source/extend/object-store.md → Status: 502 [✖] NVIDIA#110 → Status: 502 (node:10225) [DEP0184] DeprecationWarning: Instantiating Gunzip without the 'new' keyword has been deprecated. (Use `node --trace-deprecation ...` to show where the warning was created) (node:10224) [DEP0184] DeprecationWarning: Instantiating Gunzip without the 'new' keyword has been deprecated. (Use `node --trace-deprecation ...` to show where the warning was created) (node:10226) [DEP0184] DeprecationWarning: Instantiating Gunzip without the 'new' keyword has been deprecated. (Use `node --trace-deprecation ...` to show where the warning was created) ``` Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Chores** * Updated the markdown link-check pre-commit hook configuration to exclude the changelog file from link validation. This addition complements existing exclusions for package metadata documentation, improving the efficiency of continuous integration validation processes. Authors: - Bryan Bednarski (https://github.com/bbednarski9) Approvers: - Will Killian (https://github.com/willkill07) URL: NVIDIA#1653
Description
This is an artifact of the examples reorg from NAT 1.2
Closes
By Submitting this PR I confirm:
Summary by CodeRabbit