fix: reintroduce --all-files to pre-commit CI

[willkill07]

Description

Closes

By Submitting this PR I confirm:

• I am familiar with the Contributing Guidelines.
• We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  • Any contribution which contains commits that are not Signed-Off will not be accepted.
• When the PR is ready for review, new or existing tests cover these changes.
• When the PR is ready for review, the documentation is up to date with these changes.

Summary by CodeRabbit

• Chores
  • Enhanced CI/CD validation by expanding pre-commit checks to run on all files in the codebase, strengthening overall code quality standards.

[coderabbitai]

Walkthrough

This change modifies the pre-commit check invocation in the CI script to run on all files instead of changed files only, by adding the --all-files flag. Error handling and subsequent checks remain unchanged.

Changes

Cohort / File(s)	Change Summary
CI Pre-commit Scope Expansion ci/scripts/checks.sh	Modified pre-commit command invocation to include --all-files flag, expanding validation scope from changed files to all files; error-handling and subsequent check logic remain unchanged

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "fix: reintroduce --all-files to pre-commit CI" is concise at 47 characters (well within the 72-character limit), descriptive in conveying the specific change being made, and uses imperative mood with "reintroduce" as the action verb following the conventional commit format prefix. The title is fully related to the main changeset, which modifies ci/scripts/checks.sh to add the --all-files flag back to the pre-commit invocation, precisely matching the stated objective to "reintroduce --all-files to pre-commit CI." The title accurately summarizes the primary change without being misleading or vague.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ce0596 and 2d6a12c.

📒 Files selected for processing (1)

• ci/scripts/checks.sh (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

{scripts/**,ci/scripts/**}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

Shell or utility scripts belong in scripts/ or ci/scripts/ and must not be mixed with library code

Files:

• ci/scripts/checks.sh

**/*

⚙️ CodeRabbit configuration file

**/*: # Code Review Instructions

• Ensure the code follows best practices and coding standards. - For Python code, follow
  PEP 20 and
  PEP 8 for style guidelines.
• Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
  Example:

  def my_function(param1: int, param2: str) -> bool:
      pass

• For Python exception handling, ensure proper stack trace preservation:
  • When re-raising exceptions: use bare raise statements to maintain the original stack trace,
    and use logger.error() (not logger.exception()) to avoid duplicate stack trace output.
  • When catching and logging exceptions without re-raising: always use logger.exception()
    to capture the full stack trace information.

Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any

words listed in the ci/vale/styles/config/vocabularies/nat/reject.txt file, words that might appear to be
spelling mistakes but are listed in the ci/vale/styles/config/vocabularies/nat/accept.txt file are OK.

Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,

and should contain an Apache License 2.0 header comment at the top of each file.

• Confirm that copyright years are up-to date whenever a file is changed.

Files:

• ci/scripts/checks.sh

🧠 Learnings (3)

📓 Common learnings

Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Run pre-commit (pre-commit run --all-files) locally before pushing; CI fails if formatting is wrong

📚 Learning: 2025-09-23T18:39:15.023Z

Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Run pre-commit (pre-commit run --all-files) locally before pushing; CI fails if formatting is wrong

Applied to files:

• ci/scripts/checks.sh

📚 Learning: 2025-09-23T18:39:15.023Z

Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Do not commit code that fails pre-commit or ci/scripts/run_ci_local.sh check

Applied to files:

• ci/scripts/checks.sh

🔇 Additional comments (1)

ci/scripts/checks.sh (1)

23-23: LGTM!

Adding --all-files to the pre-commit invocation aligns with the PR objective and the best practice documented in learnings. This expands the scope of checks to the entire codebase rather than just changed files, ensuring comprehensive formatting and linting coverage in CI. Error handling remains correct with the return value properly captured and aggregated into the exit condition.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[willkill07]

/merge